Option name changed

src/playwright-api/makeTest.ts

@@ -33,7 +33,7 @@ export const makeTest = (
     pauseAnimationAtEnd: [undefined, { option: true }],
     prefersReducedMotion: [undefined, { option: true }],
     resourceArchiveTimeout: [DEFAULT_GLOBAL_RESOURCE_ARCHIVE_TIMEOUT_MS, { option: true }],
-    allowedExternalDomains: [[], { option: true }],
+    allowedArchiveDomains: [[], { option: true }],
 
     save: [
       async (
@@ -47,7 +47,7 @@ export const makeTest = (
           pauseAnimationAtEnd,
           prefersReducedMotion,
           resourceArchiveTimeout,
-          allowedExternalDomains,
+          allowedArchiveDomains,
         },
         use,
         testInfo
@@ -66,7 +66,7 @@ export const makeTest = (
         const completeArchive = await createResourceArchive({
           page,
           networkTimeout: resourceArchiveTimeout,
-          allowedExternalDomains,
+          allowedArchiveDomains,
         });
         await use();
 

src/resource-archive/index.test.ts

@@ -173,7 +173,7 @@ describe('new', () => {
 
     const complete = await createResourceArchive({
       page,
-      allowedExternalDomains: [
+      allowedArchiveDomains: [
         // external origins we allow-list
         'https://i-ama.fake',
         'https://another-domain.com',

src/resource-archive/index.ts

@@ -30,7 +30,7 @@ class Watcher {
    Specifies which domains (origins) we should archive resources for (by default we only archive same-origin resources).
    Useful in situations where the environment running the archived storybook (e.g. in CI) may be restricted to an intranet or other domain restrictions
   */
-  private allowedExternalDomains: string[];
+  private allowedArchiveDomains: string[];
 
   /**
    * We assume the first URL loaded after @watch is called is the base URL of the
@@ -51,7 +51,7 @@ class Watcher {
     allowedDomains?: string[]
   ) {
     this.globalNetworkTimeoutMs = networkTimeoutMs;
-    this.allowedExternalDomains = allowedDomains || [];
+    this.allowedArchiveDomains = allowedDomains || [];
   }
 
   async watch() {
@@ -141,7 +141,7 @@ class Watcher {
 
     const isRequestFromAllowedDomain =
       requestUrl.origin === this.firstUrl.origin ||
-      this.allowedExternalDomains.includes(requestUrl.origin);
+      this.allowedArchiveDomains.includes(requestUrl.origin);
 
     logger.log(
       'requestPaused',
@@ -229,16 +229,16 @@ class Watcher {
 export async function createResourceArchive({
   page,
   networkTimeout,
-  allowedExternalDomains,
+  allowedArchiveDomains,
 }: {
   page: Page;
   networkTimeout?: number;
-  allowedExternalDomains?: string[];
+  allowedArchiveDomains?: string[];
 }): Promise<() => Promise<ResourceArchive>> {
   const watcher = new Watcher(
     page,
     networkTimeout ?? DEFAULT_GLOBAL_RESOURCE_ARCHIVE_TIMEOUT_MS,
-    allowedExternalDomains
+    allowedArchiveDomains
   );
   await watcher.watch();
 

src/types.ts

@@ -27,7 +27,7 @@ export interface ChromaticConfig {
   // domains (besides localhost) that assets should be archived from
   // (needed when, for example, CI environment can't access the archives later on)
   // ex: https://www.some-domain.com
-  allowedExternalDomains?: string[];
+  allowedArchiveDomains?: string[];
 }
 
 export interface ChromaticStorybookParameters extends Omit<ChromaticConfig, 'disableAutoCapture'> {