Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop official support for Node 14/16 #839

Merged
merged 14 commits into from
Nov 9, 2023
Merged

Drop official support for Node 14/16 #839

merged 14 commits into from
Nov 9, 2023

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Oct 18, 2023 •
edited
Loading

Fixes AP-3324

This makes our CI config in line with the latest Node LTS, and limits official CLI support to Node 18+ (currently in maintenance). The CLI compilation target is still Node 16 (unchanged) to avoid breaking changes. The GitHub Action is now compiled for and configured to run on Node 20.

📦 Published PR as canary version: 8.0.0--canary.839.6812102149.0

✨ Test out this PR locally via:

npm install [email protected]
# or 
yarn add [email protected]

@ghengeveld ghengeveld added the major Auto: Increment the major version when merged label Oct 18, 2023
@ghengeveld ghengeveld changed the title Use Node LTS in CI workflows and drop Node 14/16 support Drop support for Node 14/16, use Node LTS in CI and upgrade TypeScript/ESLint to work with Node 18 Oct 18, 2023
@ghengeveld ghengeveld requested a review from ndelangen October 18, 2023 09:53
@linear
Copy link

linear bot commented Oct 18, 2023

AP-3324 Feature Request - upgrade Chromatic CLI to support Node 18 & 20

What

We recently upgraded Chromatic to Node 16; however, this is the second request I've seen to upgrade Chromatic to Node 18. Chromatic currently only guarantees support for Node 14.18.x through Node 16.19.1.

Why

Some users who have upgraded to Node 18 have had to downgrade back to a supported version of Node; this user specifically reported they downgraded since Chromatic would not link to PRs after they upgraded to Node 18.

tmeasday
tmeasday requested changes Oct 20, 2023
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm inclined to say the cost benefit of a few extra lines in our bundle to support node 16 is worth the benefit of not having to unexpectedly telling users on older versions of SB to upgrade node version.

I'm OK with saying in our README that it's not officially supported though. WDTY?

tsup.config.ts Outdated Show resolved Hide resolved
tmeasday
tmeasday approved these changes Oct 22, 2023
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghengeveld ghengeveld changed the title Drop support for Node 14/16, use Node LTS in CI and upgrade TypeScript/ESLint to work with Node 18 Drop official support for Node 14/16 Oct 24, 2023
@ghengeveld ghengeveld added this pull request to the merge queue Nov 9, 2023
Merged via the queue into main with commit 3a2eb3b Nov 9, 2023
14 checks passed
@ghengeveld ghengeveld deleted the deprecate-node-16 branch November 9, 2023 13:23
@ghengeveld
Copy link
Member Author

🚀 PR was released in v8.0.0 🚀

@ghengeveld ghengeveld added the prerelease Verdict: This change is available in a prerelease label Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thafryer thafryer thafryer approved these changes

@tmeasday tmeasday tmeasday approved these changes

@ndelangen ndelangen Awaiting requested review from ndelangen

Assignees
No one assigned
Labels
major Auto: Increment the major version when merged prerelease Verdict: This change is available in a prerelease
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ghengeveld @tmeasday @ndelangen @thafryer