Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in project metadata gathering causing build failures #1131

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

jmhobbs
Copy link
Contributor

@jmhobbs jmhobbs commented Dec 11, 2024

Unintentionally, the steps to gather project metadata were causing builds to fail if there was an error.
As this data is not required, we should not fail the whole process if one of these fail.

This appears to be the original intention (with existing try/catch) but async returns bypassed them.

Additionally, the timeout on getCommittedFileCount was reduced, as an up to 20s slowdown for non-critical information was too high.

📦 Published PR as canary version: 11.20.3--canary.1131.12283964969.0

✨ Test out this PR locally via:

npm install [email protected]
# or 
yarn add [email protected]

@jmhobbs jmhobbs requested a review from a team December 11, 2024 17:20
@jmhobbs jmhobbs self-assigned this Dec 11, 2024
Copy link
Contributor

github-actions bot commented Dec 11, 2024

📦 Package Size: 5448 KB

@jmhobbs jmhobbs added patch Auto: Increment the patch version when merged release Auto: Create a `latest` release when merged labels Dec 11, 2024
This is not required information for the build, and as such failures
must not stop the process.
@jmhobbs jmhobbs force-pushed the jmhobbs/cap-2564-getcommittedfilecount-causing-failures branch from 4b44b53 to 9f23eea Compare December 11, 2024 17:41
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 80f85041 86.67% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (80f8504) Report Missing Report Missing Report Missing
Head commit (9f23eea) 7304 5031 68.88%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1131) 15 13 86.67%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@jmhobbs jmhobbs added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit 46d617e Dec 11, 2024
20 checks passed
@jmhobbs jmhobbs deleted the jmhobbs/cap-2564-getcommittedfilecount-causing-failures branch December 11, 2024 19:59
@chromatic-ci-bot
Copy link
Collaborator

🚀 PR was released in v11.20.2 🚀

@chromatic-ci-bot chromatic-ci-bot added the released Verdict: This issue/pull request has been released label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Auto: Increment the patch version when merged release Auto: Create a `latest` release when merged released Verdict: This issue/pull request has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants