Don't normalize package.json fields

chromaui · Jan 16, 2025 · e9d7fa8 · e9d7fa8
1 parent 78b3cd0
commit e9d7fa8
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 2 deletions.
diff --git a/node-src/__mocks__/invalidPackageJson/package.json b/node-src/__mocks__/invalidPackageJson/package.json
@@ -0,0 +1,4 @@
+{
+  "name": "chromatic",
+  "version": "invalid-semver"
+}
diff --git a/node-src/index.test.ts b/node-src/index.test.ts
@@ -4,10 +4,11 @@ import { execaCommand as execaDefault } from 'execa';
 import jsonfile from 'jsonfile';
 import { confirm } from 'node-ask';
 import fetchDefault from 'node-fetch';
+import path from 'path';
 import { Readable } from 'stream';
 import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
 
-import { getGitInfo, runAll } from '.';
+import { getGitInfo, run, runAll } from '.';
 import * as git from './git/git';
 import { DNSResolveAgent } from './io/getDNSResolveAgent';
 import * as checkPackageJson from './lib/checkPackageJson';
@@ -853,3 +854,14 @@ describe('getGitInfo', () => {
     });
   });
 });
+
+describe('parsing package.json', () => {
+  it('should handle invalid `version` strings', async () => {
+    vi.spyOn(process, 'cwd').mockReturnValue(
+      path.resolve('./node-src/__mocks__/invalidPackageJson')
+    );
+
+    const result = await run({ flags: { dryRun: true } });
+    expect(result.code).toBeDefined();
+  });
+});
diff --git a/node-src/index.ts b/node-src/index.ts
@@ -116,7 +116,9 @@ export async function run({
     log = createLogger(config.flags, config.extraOptions),
   } = extraOptions || {};
 
-  const packageInfo = await readPackageUp({ cwd: process.cwd() });
+  // We don't normalize because if the `version` field isn't a proper semver string, the process
+  // silently exits.
+  const packageInfo = await readPackageUp({ cwd: process.cwd(), normalize: false });
   if (!packageInfo) {
     log.error(noPackageJson());
     process.exit(253);

diff --git a/node-src/lib/parseArguments.ts b/node-src/lib/parseArguments.ts
@@ -76,6 +76,11 @@ export default function parseArguments(argv: string[]) {
       argv,
       booleanDefault: undefined,
       description: false,
+
+      // Prevent meow from parsing the project's package.json file because if the `version` field
+      // isn't a proper semver string, the process silently exits.
+      pkg: {},
+
       version: pkg.version,
       flags: {
         // Required options