-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(cyg-get) Space in $cygRoot #2495
base: master
Are you sure you want to change the base?
Conversation
Correct a bug when $cygRoot contain space.
✅ Package verification completed without issues. PR is now pending human review |
Please go back to the description and amend it to provide the correct information and ensure you read the required guidelines and make the necessary changes. |
@pauby I don't know how to complete "Open issues" in "Original Location". |
The last bit needs to be removed. As the comments on the template indicate, its only for migrations. Not that I haven't looked at this package for this PR, but it may be necessary for a new package to be released manually. |
@pauby Can I help you to create the new version ? |
@jccolson I'm not sure what you are asking. I am not creating a new version. |
@pauby You say : "it may be necessary for a new package to be released manually". It's not a new version of cyg-get package ? |
I understand now. Thanks for clarifying. I am unlikely to be releasing the new package. Whoever picks up this PR to review will likely do that. |
Correct a bug when $cygRoot contain space.
Description
Adding some " to allow space in variable $cygRoot.
Motivation and Context
If CygWin is installed in "C:\Program Files\CygWin64", "cyg-get firefox" install defaults packages and firefox in the directory "C:\Program".
#2489
How Has this Been Tested?
choco install -y --params "/InstallDir:'C:\Program Files\CygWin64' /site:'ftp://ftp-stud.hs-esslingen.de/pub/Mirrors/sources.redhat.com/cygwin/'" Cygwin
choco install -y cyg-get
cyg-get install firefox
Screenshot (if appropriate, usually isn't needed):
Types of changes
Checklist: