test codescanning alert behavior2 #49
Conversation
chmeliik
commented
Jul 19, 2024
chmeliik
commented
- test: hardcode rule in sarif output
- test: introduce warning
is this why the alert is not disappearing?
Signed-off-by: Adam Cmiel <[email protected]>
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
.github/workflows/release.yaml
Outdated
| @@ -25,7 +25,7 @@ | |||
| image_without_digest=${image%@*} | |||
| version=${image_without_digest##*:} | |||
|
|
|||
| if [[ "$tag" != "$version" ]]; then | |||
| if [[ $tag != $version ]]; then | |||
Check warning
Code scanning / shellcheck
SC2053 Warning
There was a problem hiding this comment.
hmm, nope, the missing rules property is not why the alert is not disappearing :(
Signed-off-by: Adam Cmiel <[email protected]>
