packedOwnership as lengthless array #394
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_packedOwnership
access was performing asha3
op for every new index but as these are consecutive they can be stored as a regular array offset from a base storage location irrespective of the start token id. Only onesha3
is required instead of one per index used. Solidity effectively uses this technique for its arrays but also stores array length, which we don't need to do.Optimised
_packedOwnershipOf
accordingly.Pros
Reduces gas usage slightly in common functions but more significantly in bulk transfers (figures below).
Cons
22,772 additional deployment cost
Code readability
New
Previous