return new vectors from extensions

chirpxiv · Apr 16, 2023 · 99b34d0 · 99b34d0
1 parent c3e1ee5
commit 99b34d0
Showing 1 changed file with 20 additions and 22 deletions.
diff --git a/PalettePlus/Extensions/Vector.cs b/PalettePlus/Extensions/Vector.cs
@@ -3,28 +3,26 @@
 
 namespace PalettePlus.Extensions {
 	internal static class VectorExtensions {
-		internal static void RgbSqrt(this Vector3 vec) {
-			vec.X = (float)Math.Sqrt(vec.X);
-			vec.Y = (float)Math.Sqrt(vec.Y);
-			vec.Z = (float)Math.Sqrt(vec.Z);
-		}
-
-		internal static void RgbSqrt(this Vector4 vec) {
-			vec.X = (float)Math.Sqrt(vec.X);
-			vec.Y = (float)Math.Sqrt(vec.Y);
-			vec.Z = (float)Math.Sqrt(vec.Z);
-		}
+		internal static Vector3 RgbSqrt(this Vector3 vec) => new(
+			(float)Math.Sqrt(vec.X),
+			(float)Math.Sqrt(vec.Y),
+			(float)Math.Sqrt(vec.Z)
+		);
 
-		internal static void RgbPow2(this Vector3 vec) {
-			vec.X *= vec.X;
-			vec.Y *= vec.Y;
-			vec.Z *= vec.Z;
-		}
-
-		internal static void RgbPow2(this Vector4 vec) {
-			vec.X *= vec.X;
-			vec.Y *= vec.Y;
-			vec.Z *= vec.Z;
-		}
+		internal static Vector4 RgbSqrt(this Vector4 vec) => new(
+			(float)Math.Sqrt(vec.X),
+			(float)Math.Sqrt(vec.Y),
+			(float)Math.Sqrt(vec.Z),
+			vec.W
+		);
+
+		internal static Vector3 RgbPow2(this Vector3 vec) => vec * vec;
+
+		internal static Vector4 RgbPow2(this Vector4 vec) => new(
+			vec.X * vec.X,
+			vec.Y * vec.Y,
+			vec.Z * vec.Z,
+			vec.W
+		);
 	}
 }