Remove some std::-headers not used in headers.

chipsalliance · Feb 23, 2024 · 4aa55d0 · 4aa55d0
1 parent 31ac573
commit 4aa55d0
Show file tree

Hide file tree

Showing 111 changed files with 57 additions and 351 deletions.
diff --git a/common/analysis/BUILD b/common/analysis/BUILD
@@ -107,7 +107,6 @@ cc_test(
         ":command-file-lexer",
         "//common/lexer:lexer-test-util",
         "//common/text:token-info",
-        "@com_google_absl//absl/strings",
         "@com_google_absl//absl/strings:string_view",
         "@com_google_googletest//:gtest",
         "@com_google_googletest//:gtest_main",
@@ -134,7 +133,6 @@ cc_library(
         "//common/util:container-iterator-range",
         "//common/util:container-util",
         "//common/util:file-util",
-        "//common/util:interval-set",
         "//common/util:iterator-range",
         "//common/util:logging",
         "@com_google_absl//absl/status",
@@ -193,7 +191,6 @@ cc_library(
         "//common/text:tree-utils",
         "//common/util:algorithm",
         "//common/util:logging",
-        "@com_google_absl//absl/strings",
         "@com_google_absl//absl/strings:string_view",
         "@com_google_googletest//:gtest",  # for library testonly
     ],
@@ -262,7 +259,6 @@ cc_library(
         ":syntax-tree-linter",
         "//common/text:text-structure",
         "//common/util:logging",
-        "@com_google_absl//absl/strings",
         "@com_google_absl//absl/strings:string_view",
         "@com_google_googletest//:gtest",  # for library testonly
     ],
@@ -316,9 +312,7 @@ cc_library(
         ":lint-rule-status",
         ":linter-test-utils",
         ":text-structure-linter",
-        "//common/text:symbol",
         "//common/util:logging",
-        "@com_google_absl//absl/status",
         "@com_google_absl//absl/strings:string_view",
         "@com_google_googletest//:gtest",  # for library testonly
     ],
@@ -438,7 +432,6 @@ cc_test(
         ":line-linter",
         ":lint-rule-status",
         "//common/text:token-info",
-        "@com_google_absl//absl/strings",
         "@com_google_absl//absl/strings:string_view",
         "@com_google_googletest//:gtest",
         "@com_google_googletest//:gtest_main",
@@ -469,7 +462,6 @@ cc_test(
     srcs = ["syntax_tree_search_test.cc"],
     deps = [
         ":syntax-tree-search",
-        "//common/analysis/matcher",
         "//common/analysis/matcher:matcher-builders",
         "//common/text:symbol",
         "//common/text:syntax-tree-context",
@@ -519,7 +511,6 @@ cc_test(
         ":token-stream-linter",
         "//common/text:token-info",
         "//common/text:token-stream-view",
-        "@com_google_absl//absl/strings",
         "@com_google_absl//absl/strings:string_view",
         "@com_google_googletest//:gtest",
         "@com_google_googletest//:gtest_main",

diff --git a/common/analysis/line_lint_rule.h b/common/analysis/line_lint_rule.h
@@ -19,8 +19,6 @@
 #ifndef VERIBLE_COMMON_ANALYSIS_LINE_LINT_RULE_H_
 #define VERIBLE_COMMON_ANALYSIS_LINE_LINT_RULE_H_
 
-#include <cstddef>
-
 #include "absl/strings/string_view.h"
 #include "common/analysis/lint_rule.h"
 

diff --git a/common/analysis/lint_rule.h b/common/analysis/lint_rule.h
@@ -18,8 +18,6 @@
 #ifndef VERIBLE_COMMON_ANALYSIS_LINT_RULE_H_
 #define VERIBLE_COMMON_ANALYSIS_LINT_RULE_H_
 
-#include <string>
-
 #include "absl/status/status.h"
 #include "absl/strings/string_view.h"
 #include "common/analysis/lint_rule_status.h"

diff --git a/common/analysis/lint_rule_status.h b/common/analysis/lint_rule_status.h
@@ -17,7 +17,6 @@
 #ifndef VERIBLE_COMMON_ANALYSIS_LINT_RULE_STATUS_H_
 #define VERIBLE_COMMON_ANALYSIS_LINT_RULE_STATUS_H_
 
-#include <fstream>
 #include <functional>
 #include <initializer_list>
 #include <iosfwd>

diff --git a/common/analysis/lint_waiver.h b/common/analysis/lint_waiver.h
@@ -15,7 +15,6 @@
 #ifndef VERIBLE_COMMON_ANALYSIS_LINT_WAIVER_H_
 #define VERIBLE_COMMON_ANALYSIS_LINT_WAIVER_H_
 
-#include <cstddef>
 #include <map>
 #include <regex>  // NOLINT
 #include <set>
@@ -27,7 +26,6 @@
 #include "common/strings/position.h"
 #include "common/text/text_structure.h"
 #include "common/util/container_util.h"
-#include "common/util/interval_set.h"
 
 namespace verible {
 

diff --git a/common/analysis/matcher/BUILD b/common/analysis/matcher/BUILD
@@ -156,7 +156,6 @@ cc_library(
         "//common/text:tree-utils",
         "//common/text:visitors",
         "@com_google_absl//absl/status",
-        "@com_google_absl//absl/strings",
         "@com_google_absl//absl/strings:string_view",
         "@com_google_googletest//:gtest",  # for library testonly
     ],

diff --git a/common/analysis/syntax_tree_search_test_utils.h b/common/analysis/syntax_tree_search_test_utils.h
@@ -15,10 +15,8 @@
 #ifndef VERIBLE_COMMON_ANALYSIS_SYNTAX_TREE_SEARCH_TEST_UTILS_H_
 #define VERIBLE_COMMON_ANALYSIS_SYNTAX_TREE_SEARCH_TEST_UTILS_H_
 
-#include <functional>
 #include <initializer_list>
 #include <iosfwd>
-#include <string>
 #include <vector>
 
 #include "absl/strings/string_view.h"

diff --git a/common/analysis/text_structure_linter_test_utils.h b/common/analysis/text_structure_linter_test_utils.h
@@ -15,17 +15,14 @@
 #ifndef VERIBLE_COMMON_ANALYSIS_TEXT_STRUCTURE_LINTER_TEST_UTILS_H_
 #define VERIBLE_COMMON_ANALYSIS_TEXT_STRUCTURE_LINTER_TEST_UTILS_H_
 
-#include <cstdint>
 #include <memory>
 #include <utility>
 #include <vector>
 
-#include "absl/status/status.h"
 #include "absl/strings/string_view.h"
 #include "common/analysis/lint_rule_status.h"
 #include "common/analysis/linter_test_utils.h"
 #include "common/analysis/text_structure_linter.h"
-#include "common/text/symbol.h"
 #include "common/util/logging.h"
 #include "gtest/gtest.h"
 

diff --git a/common/formatting/BUILD b/common/formatting/BUILD
@@ -112,12 +112,10 @@ cc_test(
     srcs = ["format_token_test.cc"],
     deps = [
         ":format-token",
-        ":unwrapped-line",
         ":unwrapped-line-test-utils",
         "//common/strings:position",
         "//common/text:token-info",
         "//common/util:range",
-        "@com_google_absl//absl/strings",
         "@com_google_absl//absl/strings:string_view",
         "@com_google_googletest//:gtest",
         "@com_google_googletest//:gtest_main",
@@ -413,8 +411,6 @@ cc_test(
         ":unwrapped-line-test-utils",
         "//common/text:token-info",
         "//common/util:logging",
-        "@com_google_absl//absl/memory",
-        "@com_google_absl//absl/strings",
         "@com_google_absl//absl/strings:string_view",
         "@com_google_googletest//:gtest",
         "@com_google_googletest//:gtest_main",

diff --git a/common/formatting/format_token.h b/common/formatting/format_token.h
@@ -15,7 +15,6 @@
 #ifndef VERIBLE_COMMON_FORMATTING_FORMAT_TOKEN_H_
 #define VERIBLE_COMMON_FORMATTING_FORMAT_TOKEN_H_
 
-#include <algorithm>
 #include <cstddef>
 #include <iosfwd>
 #include <string>

diff --git a/common/formatting/layout_optimizer.h b/common/formatting/layout_optimizer.h
@@ -20,19 +20,8 @@
 #ifndef VERIBLE_VERILOG_FORMATTING_LAYOUT_OPTIMIZER_H_
 #define VERIBLE_VERILOG_FORMATTING_LAYOUT_OPTIMIZER_H_
 
-#include <algorithm>
-#include <iterator>
-#include <ostream>
-#include <type_traits>
-#include <vector>
-
-#include "absl/container/fixed_array.h"
-#include "absl/strings/str_cat.h"
-#include "absl/strings/str_join.h"
 #include "common/formatting/basic_format_style.h"
 #include "common/formatting/token_partition_tree.h"
-#include "common/formatting/unwrapped_line.h"
-#include "common/util/vector_tree.h"
 
 namespace verible {
 

diff --git a/common/formatting/state_node.h b/common/formatting/state_node.h
@@ -17,7 +17,6 @@
 
 #include <cstddef>
 #include <iosfwd>
-#include <iterator>
 #include <memory>
 #include <stack>
 #include <vector>

diff --git a/common/lexer/BUILD b/common/lexer/BUILD
@@ -63,7 +63,6 @@ cc_library(
         "//common/text:token-info",
         "//common/text:token-info-test-util",
         "//common/util:logging",
-        "@com_google_absl//absl/strings",
         "@com_google_absl//absl/strings:string_view",
         "@com_google_googletest//:gtest",  # for library testonly
     ],
@@ -76,7 +75,6 @@ cc_test(
         ":lexer-test-util",
         "//common/text:constants",
         "//common/text:token-info",
-        "//common/util:logging",
         "@com_google_absl//absl/strings",
         "@com_google_absl//absl/strings:string_view",
         "@com_google_googletest//:gtest",

diff --git a/common/lexer/flex_lexer_adapter.h b/common/lexer/flex_lexer_adapter.h
@@ -32,7 +32,6 @@
 #ifndef VERIBLE_COMMON_LEXER_FLEX_LEXER_ADAPTER_H_
 #define VERIBLE_COMMON_LEXER_FLEX_LEXER_ADAPTER_H_
 
-#include <cstdlib>
 #include <iostream>
 #include <sstream>  // IWYU pragma: keep  // for ostringstream
 #include <string>

diff --git a/common/lexer/lexer_test_util.h b/common/lexer/lexer_test_util.h
@@ -25,7 +25,6 @@
 #include <cstddef>
 #include <initializer_list>
 #include <iosfwd>
-#include <string>
 #include <vector>
 
 #include "absl/strings/string_view.h"

diff --git a/common/lsp/BUILD b/common/lsp/BUILD
@@ -53,7 +53,6 @@ cc_library(
     features = ["-use_header_modules"],  # precompiled headers incompatible with -fexceptions.
     deps = [
         "//common/util:logging",
-        "@com_google_absl//absl/strings",
         "@com_google_absl//absl/strings:string_view",
         "@jsonhpp",
     ],
@@ -69,8 +68,6 @@ cc_test(
     features = ["-use_header_modules"],  # precompiled headers incompatible with -fexceptions.
     deps = [
         ":json-rpc-dispatcher",
-        "@com_google_absl//absl/status",
-        "@com_google_absl//absl/strings",
         "@com_google_absl//absl/strings:string_view",
         "@com_google_googletest//:gtest",
         "@com_google_googletest//:gtest_main",

diff --git a/common/parser/BUILD b/common/parser/BUILD
@@ -92,7 +92,6 @@ cc_test(
         "//common/text:concrete-syntax-tree",
         "//common/text:symbol",
         "//common/text:token-info",
-        "@com_google_absl//absl/strings",
         "@com_google_absl//absl/strings:string_view",
         "@com_google_googletest//:gtest",
         "@com_google_googletest//:gtest_main",

diff --git a/common/strings/BUILD b/common/strings/BUILD
@@ -43,7 +43,6 @@ cc_test(
     deps = [
         ":comment-utils",
         "//common/util:range",
-        "@com_google_absl//absl/strings",
         "@com_google_absl//absl/strings:string_view",
         "@com_google_googletest//:gtest",
         "@com_google_googletest//:gtest_main",
@@ -69,7 +68,6 @@ cc_test(
     deps = [
         ":diff",
         "//external_libs:editscript",
-        "@com_google_absl//absl/strings",
         "@com_google_absl//absl/strings:string_view",
         "@com_google_googletest//:gtest",
         "@com_google_googletest//:gtest_main",
@@ -292,8 +290,6 @@ cc_test(
     deps = [
         ":rebase",
         "//common/util:range",
-        "@com_google_absl//absl/base:core_headers",
-        "@com_google_absl//absl/strings",
         "@com_google_absl//absl/strings:string_view",
         "@com_google_googletest//:gtest",
         "@com_google_googletest//:gtest_main",
@@ -365,7 +361,6 @@ cc_test(
         ":string-memory-map",
         "//common/util:logging",
         "//common/util:range",
-        "@com_google_absl//absl/memory",
         "@com_google_absl//absl/strings:string_view",
         "@com_google_googletest//:gtest",
         "@com_google_googletest//:gtest_main",

diff --git a/common/strings/string_memory_map.h b/common/strings/string_memory_map.h
@@ -15,7 +15,6 @@
 #ifndef VERIBLE_COMMON_STRINGS_STRING_MEMORY_MAP_H_
 #define VERIBLE_COMMON_STRINGS_STRING_MEMORY_MAP_H_
 
-#include <string>
 #include <utility>
 
 #include "absl/strings/string_view.h"

diff --git a/common/text/BUILD b/common/text/BUILD
@@ -99,7 +99,6 @@ cc_test(
     deps = [
         ":concrete-syntax-leaf",
         ":token-info",
-        "@com_google_absl//absl/strings",
         "@com_google_absl//absl/strings:string_view",
         "@com_google_googletest//:gtest",
         "@com_google_googletest//:gtest_main",
@@ -385,8 +384,6 @@ cc_test(
         ":constants",
         ":token-info",
         "//common/util:range",
-        "@com_google_absl//absl/base:core_headers",
-        "@com_google_absl//absl/strings",
         "@com_google_absl//absl/strings:string_view",
         "@com_google_googletest//:gtest",
         "@com_google_googletest//:gtest_main",
@@ -400,7 +397,6 @@ cc_test(
         ":constants",
         ":token-info",
         ":token-info-json",
-        "@com_google_absl//absl/strings",
         "@com_google_absl//absl/strings:string_view",
         "@com_google_googletest//:gtest",
         "@com_google_googletest//:gtest_main",
@@ -414,8 +410,6 @@ cc_test(
     deps = [
         ":token-info",
         ":token-info-test-util",
-        "//common/util:logging",
-        "@com_google_absl//absl/strings",
         "@com_google_absl//absl/strings:string_view",
         "@com_google_googletest//:gtest",
         "@com_google_googletest//:gtest_main",
@@ -467,9 +461,7 @@ cc_test(
         "//common/util:logging",
         "//common/util:range",
         "//common/util:value-saver",
-        "@com_google_absl//absl/memory",
         "@com_google_absl//absl/status",
-        "@com_google_absl//absl/strings",
         "@com_google_absl//absl/strings:string_view",
         "@com_google_googletest//:gtest",
         "@com_google_googletest//:gtest_main",
@@ -498,7 +490,6 @@ cc_test(
         ":token-info",
         ":token-stream-view",
         ":tree-builder-test-util",
-        "@com_google_absl//absl/strings",
         "@com_google_absl//absl/strings:string_view",
         "@com_google_googletest//:gtest",
         "@com_google_googletest//:gtest_main",

diff --git a/common/text/symbol.h b/common/text/symbol.h
@@ -20,7 +20,6 @@
 
 #include <functional>
 #include <iosfwd>
-#include <memory>
 
 #include "common/text/symbol_ptr.h"  // IWYU pragma: export
 #include "common/text/token_info.h"

diff --git a/common/text/syntax_tree_context.h b/common/text/syntax_tree_context.h
@@ -20,7 +20,6 @@
 #include <functional>
 #include <initializer_list>
 #include <iterator>
-#include <vector>
 
 #include "common/text/concrete_syntax_tree.h"
 #include "common/util/auto_pop_stack.h"

diff --git a/common/text/token_stream_view.h b/common/text/token_stream_view.h
@@ -17,7 +17,6 @@
 #ifndef VERIBLE_COMMON_TEXT_TOKEN_STREAM_VIEW_H_
 #define VERIBLE_COMMON_TEXT_TOKEN_STREAM_VIEW_H_
 
-#include <cstddef>
 #include <functional>
 #include <vector>