Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fasm annotation support rebased #99

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

acomodi
Copy link
Contributor

@acomodi acomodi commented Dec 22, 2020

This PR is a rebased version of #32.

Below there is a list of outstanding discussions from #32.

Current issues

  • Attribute on wires: AFAIK this still needs to be implemented. One thing that is not entirely clear though is the use case here. Why would we need to add attributes on wires?
  • FASM prefix annotation embedded in the module name: IMO the two ways of assigning the FASM prefix (through the FASM attribute or through the model name) are not different in a restriction point of view. It is not clear to me why embedding the FASM prefix within the cell name would be better than just add the FASM_PREFIX attribute on top of the cell.
  • FASM prefix in generate statement: Unclear what is the issue here. Generate statements are useful when, for instance, there are multiple FFs with the same structure, but that requires different FASM prefixes.
    An example of this would be the FF for the xc7. Using the generate statement would allow us to have a result such as the one in the example.
  • Missing FASM feature mode test: I believe that we have this test already in this PR?

@acomodi
Copy link
Contributor Author

acomodi commented Dec 22, 2020

@mithro FYI

@acomodi acomodi force-pushed the fasm_support_rebased branch from 05f3172 to 50378ca Compare December 22, 2020 11:58
@acomodi acomodi requested a review from mithro December 22, 2020 13:31
@acomodi acomodi force-pushed the fasm_support_rebased branch 2 times, most recently from 664dab6 to e90693a Compare December 22, 2020 13:34
mkurc-ant and others added 24 commits December 22, 2020 19:25
Signed-off-by: Maciej Kurc <[email protected]>
Signed-off-by: Maciej Kurc <[email protected]>
Signed-off-by: Maciej Kurc <[email protected]>
…o create the "fasm_params" metadata section.

Signed-off-by: Maciej Kurc <[email protected]>
Signed-off-by: Maciej Kurc <[email protected]>
Signed-off-by: Maciej Kurc <[email protected]>
Signed-off-by: Maciej Kurc <[email protected]>
Signed-off-by: Alessandro Comodi <[email protected]>
@acomodi acomodi force-pushed the fasm_support_rebased branch from e90693a to 642c732 Compare December 22, 2020 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants