Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/po sm checkin forms #258

Merged
merged 7 commits into from
Sep 27, 2024
Merged

Fix/po sm checkin forms #258

merged 7 commits into from
Sep 27, 2024

Conversation

JaneMoroz
Copy link
Collaborator

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Issue link

Fixes #216

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@JaneMoroz JaneMoroz linked an issue Sep 16, 2024 that may be closed by this pull request
Copy link

vercel bot commented Sep 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chingu-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 7:56pm

Copy link
Collaborator

@Dan-Y-Ko Dan-Y-Ko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right now, I am seeing all of the questions related to PO when I'm logged in as a PO. It shouldn't display po questions when doing a checkin as a po.

so if there's a po or sm in the team, those forms will be pulled in (sm if there's sm, po if there's po, or both if there's both roles). If the user doing the checkin is a dev, all questions will be displayed. If the user is a po, exclude the po questions. If the user is a sm, exclude the sm questions.

@JaneMoroz
Copy link
Collaborator Author

right now, I am seeing all of the questions related to PO when I'm logged in as a PO. It shouldn't display po questions when doing a checkin as a po.

so if there's a po or sm in the team, those forms will be pulled in (sm if there's sm, po if there's po, or both if there's both roles). If the user doing the checkin is a dev, all questions will be displayed. If the user is a po, exclude the po questions. If the user is a sm, exclude the sm questions.

Done!

@Dan-Y-Ko Dan-Y-Ko merged commit 4fa6682 into dev Sep 27, 2024
3 checks passed
@Dan-Y-Ko Dan-Y-Ko deleted the fix/po-sm-checkin-forms branch September 27, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Product Owner part of the check in form is not shown
2 participants