Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/Fix images #226

Merged
merged 3 commits into from
Sep 10, 2024
Merged

fix/Fix images #226

merged 3 commits into from
Sep 10, 2024

Conversation

JaneMoroz
Copy link
Collaborator

Description

Best I can do, must be some Figma bug... just can't export it without this extra space at the bottom (dark mode version)

Issue link

Fixes #200

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Aug 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chingu-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 8, 2024 3:01pm

@Dan-Y-Ko
Copy link
Collaborator

@JaneMoroz what is the issue? are the images just different sizes? Maybe the design team can help resolve this in figma

@jrayDFW
Copy link

jrayDFW commented Aug 30, 2024

Hi @JaneMoroz! We were just in the meeting with Dan and the illustrations were also exporting at different sizes for me too. I figured out that it was a drop-shadow on one of the vectors that was causing an issue with the spacing on the dark mode version. I uploaded the fixed versions to this comment. Sorry about that, and I'll keep this in mind for future illustrations. Going forward, we're going to start separating out illustrations in the Design Specs so that they will for sure be the same size and should be much easier for y'all to grab.

Let me know if these work or if they need to be sized any larger if they appear blurry.

Thanks!

Light-Final Dark-Final

@Dan-Y-Ko Dan-Y-Ko merged commit 687eee8 into dev Sep 10, 2024
3 checks passed
@Dan-Y-Ko Dan-Y-Ko deleted the fix/fix-empty-state-images branch September 10, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty State Illustrations - Different Sizes Between Light and Dark Modes
3 participants