Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/sprints page #150

Closed
wants to merge 9 commits into from
Closed

Fix/sprints page #150

wants to merge 9 commits into from

Conversation

JaneMoroz
Copy link
Collaborator

@JaneMoroz JaneMoroz commented Jun 17, 2024

Description

  • a user can access all "active" teams
  • if a voyage is over but is still "active", currentSprint equals the last sprint
  • fixed notes section, it was added by default when a meeting was created
  • fixed a checkbox for safari by simply adding width and height

Issue link

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@JaneMoroz JaneMoroz requested a review from Dan-Y-Ko as a code owner June 17, 2024 15:21
Copy link

vercel bot commented Jun 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chingu-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 23, 2024 3:29pm

@JaneMoroz
Copy link
Collaborator Author

@Dan-Y-Ko I also fixed sidebar buttons. So if Jessica wants to visit team 7 pages, buttons are gonna point to team 7 pages, before they always pointed to team 6.

The calendar need to be fixed, in dashboard/page.tsx getCurrentVoyageTeam should be used instead. And maybe this page should have a wrapper component like all others, what do you think?

@Dan-Y-Ko
Copy link
Collaborator

Dan-Y-Ko commented Jun 18, 2024

Just letting you know I have seen this pr, but there's some changes to the requirements that may affect the stuff you did regarding the active teams and stuff, but I'm not sure what is finalized yet.

One of the things I will say though, is there will always be just 1 my voyage and my voyage page links. The user will be able to switch voyages and / or teams through the profile dropdown (in the top nav). But this is not something you need to worry about right now.

@JaneMoroz
Copy link
Collaborator Author

Just letting you know I have seen this pr, but there's some changes to the requirements that may affect the stuff you did regarding the active teams and stuff, but I'm not sure what is finalized yet.

One of the things I will say though, is there will always be just 1 my voyage and my voyage page links. The user will be able to switch voyages and / or teams through the profile dropdown (in the top nav). But this is not something you need to worry about right now.

I can remove the logic I added to getCurrentSprint and getCurrentVoyageTeam. What about the sidebar, should I remove the changes I've made there? If yes, we just need to keep in mind that in future the sidebar and actually the calendar need to use getCurrentVoyageTeam too, right now there're a few places with
voyageTeamMembers.some( (member) => member.voyageTeam.voyage.status.name === "Active", );

@Dan-Y-Ko
Copy link
Collaborator

Just letting you know I have seen this pr, but there's some changes to the requirements that may affect the stuff you did regarding the active teams and stuff, but I'm not sure what is finalized yet.
One of the things I will say though, is there will always be just 1 my voyage and my voyage page links. The user will be able to switch voyages and / or teams through the profile dropdown (in the top nav). But this is not something you need to worry about right now.

I can remove the logic I added to getCurrentSprint and getCurrentVoyageTeam. What about the sidebar, should I remove the changes I've made there? If yes, we just need to keep in mind that in future the sidebar and actually the calendar need to use getCurrentVoyageTeam too, right now there're a few places with voyageTeamMembers.some( (member) => member.voyageTeam.voyage.status.name === "Active", );

For now, yes. I think it'd be better to handle these adjustments we need when we have a better idea of the requirements that will be set later. Mostly because, as I said, it's not something we need to worry about right now.

@JaneMoroz
Copy link
Collaborator Author

I'll just merge it to sprints-functionality-pt5.

@JaneMoroz JaneMoroz closed this Jun 23, 2024
@JaneMoroz JaneMoroz deleted the fix/sprints-page branch July 9, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants