Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix current date #139

Merged
merged 1 commit into from
May 21, 2024
Merged

fix: fix current date #139

merged 1 commit into from
May 21, 2024

Conversation

JaneMoroz
Copy link
Collaborator

Description

  • fixed currentDate
  • removed all this convertFromISOStringToDateWithoutTimezone logic, because we call this function on the server and it already uses UTC time

Issue link

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@JaneMoroz JaneMoroz requested a review from Dan-Y-Ko as a code owner May 20, 2024 11:20
Copy link

vercel bot commented May 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chingu-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 11:20am

@Dan-Y-Ko Dan-Y-Ko merged commit 02127e9 into dev May 21, 2024
3 checks passed
@Dan-Y-Ko Dan-Y-Ko deleted the fix/-fix-current-date branch May 21, 2024 22:35
Dan-Y-Ko added a commit that referenced this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants