-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/tech stack p1 #133
Conversation
…ons & add tech button/form).
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really like the shrink solution with the avatar, but it also doesn't looks very good right now without it, so I will need to talk to design team to see what we want to do.
Some things that you can change now though:
- The buttons are way too long. They should just take up the width of its child element (so the text), with the natural padding we have in the button components themselves.
- The add tech stack input, when user clicks outside of it, it should go back to the button. You can see the features and directory page to see example of that.
- The finalize selection button is not lined up properly with the tech stack cards, it's off a bit.
- The popover (the edit/delete menu) exists already in the features page. I'd like you to make use of that. Again, I only made that with that page specifically in mind so it will need to be refactored to be re-usable. First step would be to move that component out of that folder and put it in the global component folder. Also, just move the jsx out, the logic in editpopover file should stay the same, with the new re-usable popover component replacing the UI for it. I would like to keep it simple and just make the UI re-usable and accept the functions from the outside. You might need to make the width and height props as well, either way just some ideas for you.
- The tech stack titles are missing styles
src/app/(main)/my-voyage/[teamId]/tech-stack/components/TechStackComponentWrapper.tsx
Outdated
Show resolved
Hide resolved
src/app/(main)/my-voyage/[teamId]/tech-stack/components/TechStackCard.tsx
Outdated
Show resolved
Hide resolved
Try the things suggested here: https://i.imgur.com/glEW7au.png. Also if you look at the old tech stack page spacing seems fine. Maybe have a look there to see what the difference is. Also don't worry about the avatars overlapping the ellipsis. That will never happen once this is finished. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://i.imgur.com/X3pLaIi.png when clicking into the input, the layout of the cards shifts. It shouldn't do that.
https://i.imgur.com/mVAmdwh.png the layout gets completely messed up when pressing on the ellipsis. Should look like this https://www.figma.com/design/OAKUcYBLP3UOaRlnKrcf1G/Chingu-Dashboard?node-id=14225-161630&t=ZrFqegvMqf1Geeu1-4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The alignment of the popover is still off. I think the ellipsis needs to be moved to the left of the vote button. Also, the popover should be anchored to that ellipsis. Not sure how to explain it but I think if you put position relative on the ellipsis and then put the popover under it, it will position it relative to that ellipsis, which is the intended behavior.
Description
Issue link
Fixes # (issue)
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: