Merge pull request #695 from chinapandaman/PPF-694

PPF-694: fix reportAssignmentType

PyPDFForm/font.py

@@ -42,9 +42,9 @@ def extract_font_from_text_appearance(text_appearance: str) -> Union[str, None]:
     appearance string of a text field widget.
     """
 
-    text_appearance = text_appearance.split(" ")
+    text_appearances = text_appearance.split(" ")
 
-    for each in text_appearance:
+    for each in text_appearances:
         if each.startswith("/"):
             text_segments = findall("[A-Z][^A-Z]*", each.replace("/", ""))
 

PyPDFForm/template.py

@@ -155,11 +155,11 @@ def update_text_field_attributes(
 def get_widgets_by_page(pdf: bytes) -> Dict[int, List[dict]]:
     """Iterates through a PDF and returns all widgets found grouped by page."""
 
-    pdf = PdfReader(stream_to_io(pdf))
+    pdf_file = PdfReader(stream_to_io(pdf))
 
     result = {}
 
-    for i, page in enumerate(pdf.pages):
+    for i, page in enumerate(pdf_file.pages):
         widgets = page.annotations
         result[i + 1] = []
         if widgets:

PyPDFForm/utils.py

@@ -62,10 +62,10 @@ def preview_widget_to_draw(widget: WIDGET_TYPES) -> Text:
 def remove_all_widgets(pdf: bytes) -> bytes:
     """Removes all widgets from a PDF form."""
 
-    pdf = PdfReader(stream_to_io(pdf))
+    pdf_file = PdfReader(stream_to_io(pdf))
     result_stream = BytesIO()
     writer = PdfWriter()
-    for page in pdf.pages:
+    for page in pdf_file.pages:
         if page.annotations:
             page.annotations.clear()
         writer.add_page(page)
@@ -78,10 +78,10 @@ def remove_all_widgets(pdf: bytes) -> bytes:
 def get_page_streams(pdf: bytes) -> List[bytes]:
     """Returns a list of streams where each is a page of the input PDF."""
 
-    pdf = PdfReader(stream_to_io(pdf))
+    pdf_file = PdfReader(stream_to_io(pdf))
     result = []
 
-    for page in pdf.pages:
+    for page in pdf_file.pages:
         writer = PdfWriter()
         writer.add_page(page)
         with BytesIO() as f:
@@ -96,13 +96,13 @@ def merge_two_pdfs(pdf: bytes, other: bytes) -> bytes:
     """Merges two PDFs into one PDF."""
 
     output = PdfWriter()
-    pdf = PdfReader(stream_to_io(pdf))
-    other = PdfReader(stream_to_io(other))
+    pdf_file = PdfReader(stream_to_io(pdf))
+    other_file = PdfReader(stream_to_io(other))
     result = BytesIO()
 
-    for page in pdf.pages:
+    for page in pdf_file.pages:
         output.add_page(page)
-    for page in other.pages:
+    for page in other_file.pages:
         output.add_page(page)
 
     output.write(result)

PyPDFForm/watermark.py

@@ -180,10 +180,10 @@ def merge_watermarks_with_pdf(
     """Merges watermarks with PDF."""
 
     result = BytesIO()
-    pdf = PdfReader(stream_to_io(pdf))
+    pdf_file = PdfReader(stream_to_io(pdf))
     output = PdfWriter()
 
-    for i, page in enumerate(pdf.pages):
+    for i, page in enumerate(pdf_file.pages):
         if watermarks[i]:
             watermark = PdfReader(stream_to_io(watermarks[i]))
             if watermark.pages:

pyrightconfig.json

@@ -1,7 +1,6 @@
 {
     "typeCheckingMode": "basic",
     "reportArgumentType": "none",
-    "reportAssignmentType": "none",
     "reportAttributeAccessIssue": "none",
     "reportOptionalSubscript": "none",
     "reportIndexIssue": "none",
@@ -14,5 +13,6 @@
     "reportMissingSuperCall": "error",
     "reportPrivateUsage": "error",
     "reportSelfClsParameterName": "error",
-    "reportReturnType": "error"
+    "reportReturnType": "error",
+    "reportAssignmentType": "error"
 }