Skip to content

Commit

Permalink
other: #196 🔹 remove reactive effect deps (#197)
Browse files Browse the repository at this point in the history
  • Loading branch information
@ubugeeei
ubugeeei authored Dec 30, 2023
1 parent 6960a66 commit 873da6b
Show file tree
Hide file tree
Showing 57 changed files with 2 additions and 378 deletions.
2 changes: 0 additions & 2 deletions book/impls/10_minimum_example/030_reactive_system/packages/reactivity/effect.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ const targetMap = new WeakMap<any, KeyToDepMap>();
export let activeEffect: ReactiveEffect | undefined;

export class ReactiveEffect<T = any> {
public deps: Dep[] = [];
constructor(public fn: () => T) {}

run() {
Expand All @@ -31,7 +30,6 @@ export function track(target: object, key: unknown) {

if (activeEffect) {
dep.add(activeEffect);
activeEffect.deps.push(dep);
}
}

Expand Down
2 changes: 0 additions & 2 deletions book/impls/10_minimum_example/040_vdom_system/packages/reactivity/effect.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ const targetMap = new WeakMap<any, KeyToDepMap>();
export let activeEffect: ReactiveEffect | undefined;

export class ReactiveEffect<T = any> {
public deps: Dep[] = [];
constructor(public fn: () => T) {}

run() {
Expand All @@ -31,7 +30,6 @@ export function track(target: object, key: unknown) {

if (activeEffect) {
dep.add(activeEffect);
activeEffect.deps.push(dep);
}
}

Expand Down
2 changes: 0 additions & 2 deletions book/impls/10_minimum_example/050_component_system/packages/reactivity/effect.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ const targetMap = new WeakMap<any, KeyToDepMap>();
export let activeEffect: ReactiveEffect | undefined;

export class ReactiveEffect<T = any> {
public deps: Dep[] = [];
constructor(public fn: () => T) {}

run() {
Expand All @@ -31,7 +30,6 @@ export function track(target: object, key: unknown) {

if (activeEffect) {
dep.add(activeEffect);
activeEffect.deps.push(dep);
}
}

Expand Down
2 changes: 0 additions & 2 deletions book/impls/10_minimum_example/050_component_system2/packages/reactivity/effect.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ const targetMap = new WeakMap<any, KeyToDepMap>();
export let activeEffect: ReactiveEffect | undefined;

export class ReactiveEffect<T = any> {
public deps: Dep[] = [];
constructor(public fn: () => T) {}

run() {
Expand All @@ -31,7 +30,6 @@ export function track(target: object, key: unknown) {

if (activeEffect) {
dep.add(activeEffect);
activeEffect.deps.push(dep);
}
}

Expand Down
2 changes: 0 additions & 2 deletions book/impls/10_minimum_example/050_component_system3/packages/reactivity/effect.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ const targetMap = new WeakMap<any, KeyToDepMap>();
export let activeEffect: ReactiveEffect | undefined;

export class ReactiveEffect<T = any> {
public deps: Dep[] = [];
constructor(public fn: () => T) {}

run() {
Expand All @@ -31,7 +30,6 @@ export function track(target: object, key: unknown) {

if (activeEffect) {
dep.add(activeEffect);
activeEffect.deps.push(dep);
}
}

Expand Down
2 changes: 0 additions & 2 deletions book/impls/10_minimum_example/060_template_compiler/packages/reactivity/effect.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ const targetMap = new WeakMap<any, KeyToDepMap>();
export let activeEffect: ReactiveEffect | undefined;

export class ReactiveEffect<T = any> {
public deps: Dep[] = [];
constructor(public fn: () => T) {}

run() {
Expand All @@ -31,7 +30,6 @@ export function track(target: object, key: unknown) {

if (activeEffect) {
dep.add(activeEffect);
activeEffect.deps.push(dep);
}
}

Expand Down
2 changes: 0 additions & 2 deletions book/impls/10_minimum_example/060_template_compiler2/packages/reactivity/effect.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ const targetMap = new WeakMap<any, KeyToDepMap>();
export let activeEffect: ReactiveEffect | undefined;

export class ReactiveEffect<T = any> {
public deps: Dep[] = [];
constructor(public fn: () => T) {}

run() {
Expand All @@ -31,7 +30,6 @@ export function track(target: object, key: unknown) {

if (activeEffect) {
dep.add(activeEffect);
activeEffect.deps.push(dep);
}
}

Expand Down
2 changes: 0 additions & 2 deletions book/impls/10_minimum_example/060_template_compiler3/packages/reactivity/effect.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ const targetMap = new WeakMap<any, KeyToDepMap>();
export let activeEffect: ReactiveEffect | undefined;

export class ReactiveEffect<T = any> {
public deps: Dep[] = [];
constructor(public fn: () => T) {}

run() {
Expand All @@ -31,7 +30,6 @@ export function track(target: object, key: unknown) {

if (activeEffect) {
dep.add(activeEffect);
activeEffect.deps.push(dep);
}
}

Expand Down
2 changes: 0 additions & 2 deletions book/impls/10_minimum_example/070_sfc_compiler/packages/reactivity/effect.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ const targetMap = new WeakMap<any, KeyToDepMap>();
export let activeEffect: ReactiveEffect | undefined;

export class ReactiveEffect<T = any> {
public deps: Dep[] = [];
constructor(public fn: () => T) {}

run() {
Expand All @@ -31,7 +30,6 @@ export function track(target: object, key: unknown) {

if (activeEffect) {
dep.add(activeEffect);
activeEffect.deps.push(dep);
}
}

Expand Down
2 changes: 0 additions & 2 deletions book/impls/10_minimum_example/070_sfc_compiler2/packages/reactivity/effect.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ const targetMap = new WeakMap<any, KeyToDepMap>();
export let activeEffect: ReactiveEffect | undefined;

export class ReactiveEffect<T = any> {
public deps: Dep[] = [];
constructor(public fn: () => T) {}

run() {
Expand All @@ -31,7 +30,6 @@ export function track(target: object, key: unknown) {

if (activeEffect) {
dep.add(activeEffect);
activeEffect.deps.push(dep);
}
}

Expand Down
2 changes: 0 additions & 2 deletions book/impls/10_minimum_example/070_sfc_compiler3/packages/reactivity/effect.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ const targetMap = new WeakMap<any, KeyToDepMap>();
export let activeEffect: ReactiveEffect | undefined;

export class ReactiveEffect<T = any> {
public deps: Dep[] = [];
constructor(public fn: () => T) {}

run() {
Expand All @@ -31,7 +30,6 @@ export function track(target: object, key: unknown) {

if (activeEffect) {
dep.add(activeEffect);
activeEffect.deps.push(dep);
}
}

Expand Down
2 changes: 0 additions & 2 deletions book/impls/10_minimum_example/070_sfc_compiler4/packages/reactivity/effect.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ const targetMap = new WeakMap<any, KeyToDepMap>();
export let activeEffect: ReactiveEffect | undefined;

export class ReactiveEffect<T = any> {
public deps: Dep[] = [];
constructor(public fn: () => T) {}

run() {
Expand All @@ -31,7 +30,6 @@ export function track(target: object, key: unknown) {

if (activeEffect) {
dep.add(activeEffect);
activeEffect.deps.push(dep);
}
}

Expand Down
2 changes: 0 additions & 2 deletions book/impls/20_basic_virtual_dom/010_patch_keyed_children/packages/reactivity/effect.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ const targetMap = new WeakMap<any, KeyToDepMap>();
export let activeEffect: ReactiveEffect | undefined;

export class ReactiveEffect<T = any> {
public deps: Dep[] = [];
constructor(public fn: () => T) {}

run() {
Expand All @@ -31,7 +30,6 @@ export function track(target: object, key: unknown) {

if (activeEffect) {
dep.add(activeEffect);
activeEffect.deps.push(dep);
}
}

Expand Down
2 changes: 0 additions & 2 deletions book/impls/20_basic_virtual_dom/020_bit_flags/packages/reactivity/effect.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ const targetMap = new WeakMap<any, KeyToDepMap>();
export let activeEffect: ReactiveEffect | undefined;

export class ReactiveEffect<T = any> {
public deps: Dep[] = [];
constructor(public fn: () => T) {}

run() {
Expand All @@ -31,7 +30,6 @@ export function track(target: object, key: unknown) {

if (activeEffect) {
dep.add(activeEffect);
activeEffect.deps.push(dep);
}
}

Expand Down
2 changes: 0 additions & 2 deletions book/impls/20_basic_virtual_dom/040_scheduler/packages/reactivity/effect.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ export let activeEffect: ReactiveEffect | undefined;
export type EffectScheduler = (...args: any[]) => any;

export class ReactiveEffect<T = any> {
public deps: Dep[] = [];
constructor(
public fn: () => T,
public scheduler: EffectScheduler | null = null
Expand Down Expand Up @@ -36,7 +35,6 @@ export function track(target: object, key: unknown) {

if (activeEffect) {
dep.add(activeEffect);
activeEffect.deps.push(dep);
}
}

Expand Down
2 changes: 0 additions & 2 deletions book/impls/20_basic_virtual_dom/050_next_tick/packages/reactivity/effect.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ export let activeEffect: ReactiveEffect | undefined;
export type EffectScheduler = (...args: any[]) => any;

export class ReactiveEffect<T = any> {
public deps: Dep[] = [];
constructor(
public fn: () => T,
public scheduler: EffectScheduler | null = null
Expand Down Expand Up @@ -36,7 +35,6 @@ export function track(target: object, key: unknown) {

if (activeEffect) {
dep.add(activeEffect);
activeEffect.deps.push(dep);
}
}

Expand Down
2 changes: 0 additions & 2 deletions book/impls/20_basic_virtual_dom/060_other_props/packages/reactivity/effect.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ export let activeEffect: ReactiveEffect | undefined;
export type EffectScheduler = (...args: any[]) => any;

export class ReactiveEffect<T = any> {
public deps: Dep[] = [];
constructor(
public fn: () => T,
public scheduler: EffectScheduler | null = null
Expand Down Expand Up @@ -36,7 +35,6 @@ export function track(target: object, key: unknown) {

if (activeEffect) {
dep.add(activeEffect);
activeEffect.deps.push(dep);
}
}

Expand Down
2 changes: 0 additions & 2 deletions book/impls/30_basic_reactivity_system/010_ref/packages/reactivity/effect.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ export let activeEffect: ReactiveEffect | undefined;
export type EffectScheduler = (...args: any[]) => any;

export class ReactiveEffect<T = any> {
public deps: Dep[] = [];
constructor(
public fn: () => T,
public scheduler: EffectScheduler | null = null
Expand Down Expand Up @@ -41,7 +40,6 @@ export function track(target: object, key: unknown) {
export function trackEffects(dep: Dep) {
if (activeEffect) {
dep.add(activeEffect);
activeEffect.deps.push(dep);
}
}

Expand Down
2 changes: 0 additions & 2 deletions book/impls/30_basic_reactivity_system/020_shallow_ref/packages/reactivity/effect.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ export let activeEffect: ReactiveEffect | undefined;
export type EffectScheduler = (...args: any[]) => any;

export class ReactiveEffect<T = any> {
public deps: Dep[] = [];
constructor(
public fn: () => T,
public scheduler: EffectScheduler | null = null
Expand Down Expand Up @@ -41,7 +40,6 @@ export function track(target: object, key: unknown) {
export function trackEffects(dep: Dep) {
if (activeEffect) {
dep.add(activeEffect);
activeEffect.deps.push(dep);
}
}

Expand Down
2 changes: 0 additions & 2 deletions book/impls/30_basic_reactivity_system/030_to_ref/packages/reactivity/effect.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ export let activeEffect: ReactiveEffect | undefined;
export type EffectScheduler = (...args: any[]) => any;

export class ReactiveEffect<T = any> {
public deps: Dep[] = [];
constructor(
public fn: () => T,
public scheduler: EffectScheduler | null = null
Expand Down Expand Up @@ -41,7 +40,6 @@ export function track(target: object, key: unknown) {
export function trackEffects(dep: Dep) {
if (activeEffect) {
dep.add(activeEffect);
activeEffect.deps.push(dep);
}
}

Expand Down
2 changes: 0 additions & 2 deletions book/impls/30_basic_reactivity_system/040_to_refs/packages/reactivity/effect.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ export let activeEffect: ReactiveEffect | undefined;
export type EffectScheduler = (...args: any[]) => any;

export class ReactiveEffect<T = any> {
public deps: Dep[] = [];
constructor(
public fn: () => T,
public scheduler: EffectScheduler | null = null
Expand Down Expand Up @@ -41,7 +40,6 @@ export function track(target: object, key: unknown) {
export function trackEffects(dep: Dep) {
if (activeEffect) {
dep.add(activeEffect);
activeEffect.deps.push(dep);
}
}

Expand Down
2 changes: 0 additions & 2 deletions book/impls/30_basic_reactivity_system/050_computed/packages/reactivity/effect.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ export let activeEffect: ReactiveEffect | undefined;
export type EffectScheduler = (...args: any[]) => any;

export class ReactiveEffect<T = any> {
public deps: Dep[] = [];
constructor(
public fn: () => T,
public scheduler: EffectScheduler | null = null
Expand Down Expand Up @@ -41,7 +40,6 @@ export function track(target: object, key: unknown) {
export function trackEffects(dep: Dep) {
if (activeEffect) {
dep.add(activeEffect);
activeEffect.deps.push(dep);
}
}

Expand Down
2 changes: 0 additions & 2 deletions book/impls/30_basic_reactivity_system/060_computed_setter/packages/reactivity/effect.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ export let activeEffect: ReactiveEffect | undefined;
export type EffectScheduler = (...args: any[]) => any;

export class ReactiveEffect<T = any> {
public deps: Dep[] = [];
constructor(
public fn: () => T,
public scheduler: EffectScheduler | null = null
Expand Down Expand Up @@ -41,7 +40,6 @@ export function track(target: object, key: unknown) {
export function trackEffects(dep: Dep) {
if (activeEffect) {
dep.add(activeEffect);
activeEffect.deps.push(dep);
}
}

Expand Down
2 changes: 0 additions & 2 deletions book/impls/30_basic_reactivity_system/070_watch/packages/reactivity/effect.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ export let activeEffect: ReactiveEffect | undefined;
export type EffectScheduler = (...args: any[]) => any;

export class ReactiveEffect<T = any> {
public deps: Dep[] = [];
constructor(
public fn: () => T,
public scheduler: EffectScheduler | null = null
Expand Down Expand Up @@ -41,7 +40,6 @@ export function track(target: object, key: unknown) {
export function trackEffects(dep: Dep) {
if (activeEffect) {
dep.add(activeEffect);
activeEffect.deps.push(dep);
}
}

Expand Down
2 changes: 0 additions & 2 deletions book/impls/30_basic_reactivity_system/080_watch_api_extends/packages/reactivity/effect.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ export let activeEffect: ReactiveEffect | undefined;
export type EffectScheduler = (...args: any[]) => any;

export class ReactiveEffect<T = any> {
public deps: Dep[] = [];
constructor(
public fn: () => T,
public scheduler: EffectScheduler | null = null
Expand Down Expand Up @@ -41,7 +40,6 @@ export function track(target: object, key: unknown) {
export function trackEffects(dep: Dep) {
if (activeEffect) {
dep.add(activeEffect);
activeEffect.deps.push(dep);
}
}

Expand Down
Loading

0 comments on commit 873da6b

Please sign in to comment.