Speed up build time when only plugins requirements installation #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The WORKDIR command already create the folder if missing
The dev define a new package in the requirements file. The dev run the build with `docker build`. The build recreate all the layers. If the layer is the same, docker keep it, when a layer changes, docker create the layer and all the layer after it. Moved the apt-get commands before the others steps. Moved the commands to copy of plugin and installation of plugins dependencies as last commands.
pieroit
reviewed
Nov 18, 2023
|
|
||
| ### FINISH ### | ||
| CMD python3 -m cat.main |
There was a problem hiding this comment.
We need this CMD in case you launch the image solo (out of docker compose)
There was a problem hiding this comment.
Please the PR branched from develop and towards develop
(Because there are commits on main that are not on develop and vice versa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed mkdir of folders
The WORKDIR command already create the folder if missing
Speed up build time when only plugins requirements installation
The dev define a new package in the requirements file.
The dev run the build with
docker compose build.The build recreate all the layers.
If the layer is the same, docker keep it, when a layer change, docker create the layer and all the layer after it.
Moved the apt-get commands before the others steps.
Moved the commands to copy of plugins and installation of plugins dependencies as last commands.
Related to issue, not related to issue
Type of change
Checklist: