Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: docker build #525

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Conversation

kodaline
Copy link
Contributor

Description

Issue

The pre-built docker image contains only cat/plugins folder instead all the core. This cause the current pre-built image by github action to be incomplete and to fail with error /usr/local/bin/python: No module named cat.main.

Solution

Change COPY command of the Dockerfile to include the whole cat folder and modify the docker-compose.yml accordingly to use the generated image and to not bind mount /core anymore.

Extra

Edit github action to support multi-platform build.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@kodaline
Copy link
Contributor Author

@nicola-corbellini Hi, here is the pull-request, not sure about the build action, I never tested one.
Please give it a look when you can

@pieroit
Copy link
Member

pieroit commented Oct 23, 2023

Hi @kodaline, welcome and thanks :)
I'll leave a review

docker-compose.yml Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
- Dockerfile: COPY whole cat folder in the resulting image
- github actions for multiplatform build
@kodaline kodaline force-pushed the develop_fix_dockerfile branch from 29e61c7 to c994233 Compare October 24, 2023 16:47
@kodaline kodaline requested a review from pieroit October 24, 2023 16:50
@pieroit
Copy link
Member

pieroit commented Oct 25, 2023

Thanks and welcome

@pieroit pieroit merged commit f69cbdf into cheshire-cat-ai:develop Oct 25, 2023
1 check passed
@kodaline kodaline deleted the develop_fix_dockerfile branch January 7, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants