Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respond 400 instead of 500 when first header field line starts with SP or HTAB #729

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kenballus
Copy link

@kenballus kenballus commented Jul 6, 2024

❓ What kind of change does this PR introduce?

  • 🐞 bug fix
  • 🐣 feature
  • πŸ“‹ docs update
  • πŸ“‹ tests/coverage improvement
  • πŸ“‹ refactoring
  • πŸ’₯ other

πŸ“‹ What is the related issue number (starting with #)
#728

❓ What is the current behavior? (You can also link to an open issue here)
Cheroot responds 500 when it receives a request in which the first header field line starts with SP or HTAB, due to an UnboundLocalError.

❓ What is the new behavior (if this is a feature change)?
It responds 400 instead.

πŸ“‹ Contribution checklist:

(If you're a first-timer, check out
this guide on making great pull requests)

  • I wrote descriptive pull request text above
  • I think the code is well written
  • I wrote good commit messages
  • I have squashed related commits together after
    the changes have been approved
  • Unit tests for the changes exist
  • Integration tests for the changes exist (if applicable)
  • I used the same coding conventions as the rest of the project
  • The new code doesn't generate linter offenses
  • Documentation reflects the changes
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences

This change is Reviewable

@kenballus kenballus force-pushed the main branch 2 times, most recently from bd642f1 to 3fa1439 Compare July 6, 2024 22:19
Copy link

codecov bot commented Jul 6, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 83.67%. Comparing base (1ff20b1) to head (3fa1439).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #729      +/-   ##
==========================================
+ Coverage   83.65%   83.67%   +0.02%     
==========================================
  Files          28       28              
  Lines        4166     4178      +12     
==========================================
+ Hits         3485     3496      +11     
- Misses        681      682       +1     

@kenballus kenballus force-pushed the main branch 2 times, most recently from 94d81bb to 6778ce9 Compare July 6, 2024 22:26
Prevent unhandled exception in header parsing that results in 500
responses when the first received header begins with whitespace.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant