Add a small quality-of-life change for tests #1147
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the Project and Library specs, we use an `expect` construct to ensure the build order is consistent. However, when there is a failure, we see a diff of the internal object representations. We can map the `:name` property into the construct instead to get a diff of the component names. Signed-off-by: Ryan Egesdahl <[email protected]>
deriamis
force-pushed
the
better-spec-diffs
branch
from
662a908
to
9fa105e
Compare
spec/unit/library_spec.rb
Outdated
| @@ -113,7 +113,7 @@ def generate_software(name, version, dependencies = []) | |||
| end | |||
|
|
|||
| it "returns an array of software descriptions, with all top level deps first, assuming they are not themselves transitive deps" do | |||
| expect(library.build_order).to eql( | |||
| expect(library.build_order(&:name)).to eql( | |||
There was a problem hiding this comment.
No, you aren't missing anything. I am 🤡.
This is something I was moving over from something else I was doing, and I couldn't just cherry-pick it because it was part of something larger. Looks like I missed a couple of details. I'll push up a fix.
Signed-off-by: Ryan Egesdahl <[email protected]>
deriamis
force-pushed
the
better-spec-diffs
branch
from
a6513e9
to
a171e32
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the Project and Library specs, we use an
expectconstruct to ensure the build order is consistent. However, when there is a failure, we see a diff of the internal object representations. We can map the:nameproperty into the construct instead to get a diff of the component names.Maintainers
Please ensure that you check for:
serial number
corresponding change is reviewed and there is a release plan
corresponding change is reviewed and there is a release plan