Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the WS-GUI-app #3277

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .expeditor/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,6 @@ subscriptions:
- workload: habitat-sh/habitat:main_completed:project_promoted:habitat-sh/habitat:main:current:*
actions:
- bash:.expeditor/update_habitat.sh
- workload: buildkite_build_passed:chef/chef-workstation-app:main:release:*
actions:
- bash:.expeditor/update_chef-workstation-app_to_latest.sh
- workload: chef/chef-analyze:main_completed:pull_request_merged:chef/chef-analyze:main:*
actions:
- bash:.expeditor/update_chef-analyze_to_latest.sh
Expand Down
42 changes: 0 additions & 42 deletions .expeditor/update_chef-workstation-app_to_latest.sh

This file was deleted.

1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

Chef Workstation installs everything you need to get started using Chef products on Windows, Mac and Linux. It includes:

* Chef Workstation App
* Chef Infra Client
* Chef InSpec
* Chef Habitat
Expand Down
1 change: 0 additions & 1 deletion RELEASE_PROCESS.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ Examine the [open PRs](https://github.com/chef/chef-workstation/pulls) on the Ch

Dependabot and Expeditor are configured to create PRs when dependent packages are updated. Those processes can sometimes fail or there may be a pending PR in a dependent package that should be merged. Check the following repos and ensure they have the desired PRs merged, released, and updated in Chef Workstation:

* [Chef Workstation App](https://github.com/chef/chef-workstation-app)
* [Chef CLI](https://github.com/chef/chef-cli)
* [Chef Analyze](https://github.com/chef/chef-analyze/)
* [Chef Infra Client](https://github.com/chef/chef/)
Expand Down
59 changes: 0 additions & 59 deletions docs-chef-io/content/workstation/chef-workstation-app.md

This file was deleted.

4 changes: 0 additions & 4 deletions docs-chef-io/content/workstation/install_workstation.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,6 @@ Minimum system requirements:
- Disk: 8GB
- Additional memory and storage space may be necessary to take advantage of Chef Workstation tools such as Test Kitchen which creates and manages virtualized test environments.

Additional Chef Workstation App Requirements:

- On Linux, you must have a graphical window manager running with support for system tray icons. For some distributions you may also need to install additional libraries. After you install the Chef Workstation package from the terminal, the post-install message will tell you which, if any, additional libraries are required to run the Chef Workstation App.

## Installation

The Chef Workstation installer must run as a privileged user.
Expand Down
3 changes: 1 addition & 2 deletions omnibus/config/projects/chef-workstation.rb
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@
dependency "ruby-windows-system-libraries"
end

dependency "chef-workstation-app"
dependency "uninstall-scripts"
dependency "ruby-env-script"
dependency "ruby-cleanup"
Expand Down Expand Up @@ -131,7 +130,7 @@
fast_msi true
upgrade_code "9870C512-DF2C-43D9-8C28-7ACD60ABBE27"
wix_light_extension "WixUtilExtension"
signing_identity "769E6AF679126F184850AAC7C5C823A80DB3ADAA", machine_store: false, keypair_alias: "key_495941360"
signing_identity "7D16AE73AB249D473362E9332D029089DBBB89B2", machine_store: false, keypair_alias: "key_875762014"
end

# We don't support appx builds, and they eat a lot of time.
Expand Down
68 changes: 0 additions & 68 deletions omnibus/config/software/chef-workstation-app.rb

This file was deleted.

3 changes: 0 additions & 3 deletions omnibus/files/uninstall-scripts/uninstall_chef_workstation
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,8 @@ if is_darwin; then
echo "This uninstaller will remove Chef Workstation."
sudo /bin/sh -s <<'EOF'
echo "Uninstalling Chef Workstation..."
echo " -> Removing Chef Workstation App..."
/opt/chef-workstation/bin/chef_workstation_app_launcher remove
echo " -> Removing files..."
sudo rm -rf '/opt/chef-workstation'
sudo rm -rf '/Applications/Chef Workstation App.app'
echo " -> Removing .plist for server"
sudo rm -rf '~/Library/LaunchAgents/io.chef.chef-workstation.plist'
echo " -> Removing binary links in /usr/local/bin..."
Expand Down
6 changes: 0 additions & 6 deletions omnibus/omnibus-test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,5 @@ fi
# echo "--- Ensure that 'chef-automate-collect' cli is available"
# chef exec chef-automate-collect -h

# Verify that the chef-workstation-app was installed (MacOS only)
if is_darwin; then
echo "--- Verifying that chef-workstation-app exist in /Applications directory"
test -d "/Applications/Chef Workstation App.app"
fi

echo "--- Run Workstation verification suite"
/opt/chef-workstation/embedded/bin/ruby omnibus/verification/run.rb
63 changes: 6 additions & 57 deletions omnibus/package-scripts/chef-workstation/postinst
Original file line number Diff line number Diff line change
Expand Up @@ -82,67 +82,16 @@ done

if is_darwin; then

# this will be removed when we bring back the workstation-gui changes back
FILE="$HOME/Library/LaunchAgents/io.chef.chef-workstation.plist"
FILE="$HOME/Library/LaunchAgents/io.chef.chef-workstation.app.plist"

if [ -f "$FILE" ]; then
sudo -u $USER launchctl unload $HOME/Library/LaunchAgents/io.chef.chef-workstation.plist
sudo rm -rf $HOME/Library/LaunchAgents/io.chef.chef-workstation.plist
sudo rm -rf $INSTALLER_DIR/service.txt
sudo rm -rf $INSTALLER_DIR/embedded/service
sudo -u $USER launchctl unload $HOME/Library/LaunchAgents/io.chef.chef-workstation.app.plist
sudo rm -rf $HOME/Library/LaunchAgents/io.chef.chef-workstation.app.plist
fi

# the app launcher comes from the chef-workstation-app repo, here we are just using
# it to start the app as a service on MacOS systems, it will start at boot
sudo rm -rf '/Applications/Chef Workstation App.app'
app_launcher=chef_workstation_app_launcher
su "$USER" $INSTALLER_DIR/bin/$app_launcher remove

# Close the app if it is running.
if [ $(osascript -e 'application "Chef Workstation App" is running') = 'true' ]; then
echo "Closing Chef Workstation App..."
osascript -e 'quit app "Chef Workstation App"' > /dev/null 2>&1;
fi
# chef-workstation-app is configured to build Mac as a zip file instead
# of a directory. Otherwise, the mac pkgbuild command will find the Chef Workstation App
# within the larger Chef Workstation package, and will not include it in the Chef Workstation
# package directly.
echo "Moving Chef Workstation App to the Applications folder"
pushd "$INSTALLER_DIR/components/chef-workstation-app"
# https://github.com/electron-userland/electron-builder/issues/3779
# https://github.com/electron-userland/electron-builder/issues/4299#issuecomment-544997415
ditto -x -k -V chef-workstation-app-mac.zip ./
sudo rm -rf "/Applications/Chef Workstation App.app"
sudo mv "Chef Workstation App.app" /Applications/
cp "/Applications/Chef Workstation App.app/Contents/Resources/assets/scripts/$app_launcher" $INSTALLER_DIR/bin/. || error_exit "Cannot copy $app_launcher to $INSTALLER_DIR/bin"
rm -rf "$INSTALLER_DIR/components"
popd

ln -sf $INSTALLER_DIR/bin/uninstall_chef_workstation $PREFIX/bin || error_exit "Cannot link uninstall_chef_workstation to $PREFIX/bin"

echo "Setting Chef Workstation App to run at boot..."
su "$USER" $INSTALLER_DIR/bin/$app_launcher load

echo "Launching Chef Workstation App..."
osascript -e 'open app "Chef Workstation App"' > /dev/null 2>&1;
else # linux - postinst does not run for windows.
cwa_app_path="$INSTALLER_DIR/components/chef-workstation-app/chef-workstation-app"
ldd "$cwa_app_path" | grep "not found" >/dev/null 2>&1
# 0 rc means grep found 'not found' text - and we have missing deps.
if [ $? -eq 0 ]; then
echo ""
echo "Chef Workstation ships with a toolbar application, the Chef Workstation App."
echo "To run this application some additional dependencies must be installed."
echo "Using your platform's package manager to install the 'electron' package is "
echo "the easiest way to meet the dependency requirements."
echo ""
echo "You can then launch the App by running 'chef-workstation-app'."
echo "The App will then be available in the system tray."
else
echo ""
echo "The Chef Workstation App is available."
echo ""
echo "Launch the App by running 'chef-workstation-app'."
echo "The App will then be available in the system tray."
fi
ln -sf $cwa_app_path $PREFIX/bin
fi

echo ""
Expand Down
2 changes: 1 addition & 1 deletion omnibus/package-scripts/chef-workstation/postrm
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ cleanup_symlinks() {
# Keep removed symlinks in this list, so that removal of upgraded packages still cleans up
# leftovers from older versions. We keep the push jobs values here to cleanup old releases
workstation_binaries="berks chef chef-cli chef-apply chef-shell chef-solo chef-vault cookstyle dco delivery foodcritic inspec kitchen knife ohai push-apply pushy-client pushy-service-manager chef-client mixlib-install chef-zero fauxhai"
binaries="chef-run chef-workstation-app $workstation_binaries chef-analyze hab"
binaries="chef-run $workstation_binaries chef-analyze hab"

for binary in $binaries; do
rm -f "$PREFIX/bin/$binary"
Expand Down
Loading
Loading