-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: shuffle functions #643
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pascal-Delange
force-pushed
the
pascal/refactor
branch
2 times, most recently
from
January 3, 2025 09:54
6dd050f
to
3606c59
Compare
ChibiBlasphem
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, that's a great work. I really like how you separated concerns.
Pascal-Delange
force-pushed
the
pascal/refactor
branch
from
January 10, 2025 11:15
173b044
to
992d34d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
First half of a refactor I wanted to do on the models for ast nodes & operators.
The diff is likely a bit hard to read - try to read it commit by commit if you must.
I'm mostly doing two things here. Before this PR, there were two fairly large models files:
packages/app-builder/src/models/ast-node.ts
andpackages/app-builder/src/models/editable-operators.ts
.Things I'm trying to improve
packages/app-builder/src/components/Decisions/RulesExecutions/RuleExecutionDetail.tsx
)Up next
This PR only moves things around, to try to make the file structure make more sense by separating things that should be separate. This is only half of what I wanted to do, and the other half where I actually change logic will follow in another PR (else it would be really impossible to properly read).
Continued in #646