Skip to content

Commit

Permalink
refactor: remove redundant conditional check
Browse files Browse the repository at this point in the history
  • Loading branch information
@bashbunni
bashbunni authored Nov 19, 2024
1 parent abae509 commit f1b5ff5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion get.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -530,7 +530,7 @@ func (s Style) implicitBorders() bool {
bottomSet = s.isSet(borderBottomKey)
leftSet = s.isSet(borderLeftKey)
)
if borderStyle != noBorder && !(topSet || rightSet || bottomSet || leftSet) {
return borderStyle != noBorder && !(topSet || rightSet || bottomSet || leftSet)

This comment has been minimized.

Sign in to view

Copy link
@meowgorithm

meowgorithm Nov 20, 2024

Member

@bashbunni this is a great catch but I believe you also need to remove the following line in this case.
return true
}
return false

Check failure on line 536 in get.go

View workflow job for this annotation

GitHub Actions / build / build (ubuntu-latest) 

syntax error: non-declaration statement outside function body

Check failure on line 536 in get.go

View workflow job for this annotation

GitHub Actions / coverage (^1, ubuntu-latest) 

syntax error: non-declaration statement outside function body

Check failure on line 536 in get.go

View workflow job for this annotation

GitHub Actions / coverage (^1, ubuntu-latest) 

syntax error: non-declaration statement outside function body

Check failure on line 536 in get.go

View workflow job for this annotation

GitHub Actions / lint / lint-soft (ubuntu-latest) 

expected declaration, found 'return' (typecheck)

Check failure on line 536 in get.go

View workflow job for this annotation

GitHub Actions / lint / lint (ubuntu-latest) 

expected declaration, found 'return' (typecheck)

Check failure on line 536 in get.go

View workflow job for this annotation

GitHub Actions / lint / lint (ubuntu-latest) 

expected declaration, found 'return' (typecheck)

Check failure on line 536 in get.go

View workflow job for this annotation

GitHub Actions / build / govulncheck 

expected declaration, found 'return'

Check failure on line 536 in get.go

View workflow job for this annotation

GitHub Actions / lint / lint-soft (ubuntu-latest) 

expected declaration, found 'return' (typecheck)

Check failure on line 536 in get.go

View workflow job for this annotation

GitHub Actions / lint / lint-soft (macos-latest) 

expected declaration, found 'return' (typecheck)

Check failure on line 536 in get.go

View workflow job for this annotation

GitHub Actions / lint / lint-soft (macos-latest) 

expected declaration, found 'return' (typecheck)
Expand Down

0 comments on commit f1b5ff5

Please sign in to comment.