-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: unselect selector #261
base: main
Are you sure you want to change the base?
Conversation
I would perhaps use |
Not 100% if we want this as well since this makes it look like you can select multiple options. |
@maaslalani it's just a use case as an example :) None of these pseudo radio buttons are in this pull request, in facts, this is fully backward compatible, as the base " |
This modification results in a breaking change. |
@joaogmguimaraes i see what you mean. If you set
In general, you will always got the same issue when We can address this by programmatically adding white spaces at the end of the shorter one. What do you think ? Is it worth it ? |
I think so. When |
In this library: survey Users can add icons of different sizes, but in our case, since there is already the functionality to keep the |
@joaogmguimaraes i've just pushed a naive implementation of cursors width harmonization @maaslalani about your renaming proposal |
I think we may actually want to name this |
@maaslalani i guess you mean the new In this case, what about the current |
Introduce a new style for unselected select options.
You may ask why ?
Well, before π :
And, after π :
With only
UnselectSelector
... Any opinions here ?