(v2) fix keyboard enhancements msg, expose types and track requested and active enhancements #1286
+133
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, keyboard enhancements events won't be sent to update
…ements This change exposes the `KeyboardEnhancements` type and tracks requested and active enhancements in the `Program` struct. This change also renames the `KeyboardEnhancement` type to `KeyboardEnhancementOption` and `keyboardEnhancements` to `KeyboardEnhancements` as well as `EnableKeyboardEnhancements` to `RequestKeyboardEnhancements`.
aymanbagabas
force-pushed
the
v2-enh-keeb
branch
from
3a27273 to
6e5929b
Compare
caarlos0
approved these changes
Jan 13, 2025
aymanbagabas
force-pushed
the
v2-enh-keeb
branch
from
db1597f to
6f40250
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: keyboard: expose type and track requested and active enhancements
This change exposes the
KeyboardEnhancementstype and tracks requestedand active enhancements in the
Programstruct. This change alsorenames the
KeyboardEnhancementtype toKeyboardEnhancementOptionas well as
EnableKeyboardEnhancementstoRequestKeyboardEnhancements.Fixes: #1283