Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(help): use length of groups, not items within a group, for separator behavior #569

Closed
wants to merge 1 commit into from
Closed

fix(help): use length of groups, not items within a group, for separator behavior #569

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion help/help.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ func (m Model) FullHelpView(groups [][]key.Binding) string {
out = append(out, col)

// Separator
if i < len(group)-1 {
if i < len(groups)-1 {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the case of columns containing two items, this essentially said if i < 1, add the separator. This led to only the 0th column receiving the separator, no matter how many other columns are displayed.

totalWidth += sepWidth
if m.Width > 0 && totalWidth > m.Width {
break
Expand Down
Loading