fix: make DefaultDelegate satisfy ItemDelegate interface #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maaslalani
approved these changes
Jun 21, 2024
maaslalani
reviewed
Jun 21, 2024
| @@ -127,7 +127,7 @@ func (d DefaultDelegate) Spacing() int { | |||
| } | |||
|
|
|||
| // Update checks whether the delegate's UpdateFunc is set and calls it. | |||
| func (d DefaultDelegate) Update(msg tea.Msg, m *Model) tea.Cmd { | |||
| func (d DefaultDelegate) Update(ctx tea.Context, msg tea.Msg, m *Model) tea.Cmd { | |||
There was a problem hiding this comment.
Does this not need to return the model?
There was a problem hiding this comment.
It seems the ItemDelegate interface has a signature Update(ctx tea.Context, msg tea.Msg, m *Model) tea.Cmd... So not sure if the ItemDelegate should be the same Update sig as a bubble tea model
https://github.com/charmbracelet/bubbles/blob/beta/list/list.go#L51
bashbunni
changed the title
|
Hey @aymanbagabas do you mind taking a look at this when you have a moment? |
aymanbagabas
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.