Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate revisions with event dispatcher #69

Merged
merged 14 commits into from
Sep 30, 2022
Merged

Integrate revisions with event dispatcher #69

merged 14 commits into from
Sep 30, 2022

Conversation

JoelAlphonso
Copy link
Contributor

@JoelAlphonso JoelAlphonso commented Sep 29, 2022 •
edited by mcaskill
Loading

Merging Joel_feat_revision-event into joel_feat_event-dispatcher (#64).

Changes :

Features

  • object: add an ObjectServiceProvider for object package services (117dad5)
  • revision: add properties and propertyBlacklist options for Revisions (f2cf7c9)
  • revision: add a listener to hook revision generation (4cb6fbb)
  • revision: add a revision service to handle all revision related operations (0936d20)
  • revision: add RevisionConfig.php to cast revisions config nodes to (2bc3ece)
  • revision: remove revision generation from Content.php (8fb6b25)
  • revision: use the revisions service everywhere and refactor it to require setting a model on the service (aef32f0)

Bug Fixes

  • revision: fix included properties and properties options (feddd68)

@JoelAlphonso
feat(object): add an ObjectServiceProvider for object package services
117dad5
@JoelAlphonso
refactor(revision): refactor revision object and interface to use Mod…
b41c7c2 
…elInterface as subject
@JoelAlphonso
feat(revision): remove revision generation from Content.php
8fb6b25
@JoelAlphonso
feat(revision): add a revision service to handle all revision related…
0936d20 
… operations
@JoelAlphonso
feat(revision): add a listener to hook revision generation
4cb6fbb
@JoelAlphonso
feat(revision): add RevisionConfig.php to cast revisions config nodes to
2bc3ece
@JoelAlphonso
feat(revision): add properties and propertyBlacklist options for …
f2cf7c9 
…Revisions

`properties` limits the scope of revision to only some properties while `propertyBlacklist` ensures that some properties are not processed into the revision
@JoelAlphonso
refactor(revision): refactor revision config and service to allow for…
fced96e 
… more flexible configuration
@JoelAlphonso
fix(revision): fix included properties and properties options
feddd68
@JoelAlphonso
feat(revision): use the revisions service everywhere and refactor it …
aef32f0 
…to require setting a model on the service

- a ModelInterface instance must be set on the service
- Remove RevisionableInterface.php and RevisionableTrait.php
- use dependency locator for RevisionService
@mcaskill mcaskill changed the title Pulling Joel_feat_revision-event into joel_feat_event-dispatcher Integrate revisions with event dispatcher Sep 29, 2022
mcaskill
mcaskill requested changes Sep 29, 2022
View reviewed changes
Copy link
Collaborator

@mcaskill mcaskill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the class names use Revision or Revisions plural?

  • RevisionsServiceProvider
  • RevisionsConfig
  • RevisionsModelConfig
  • RevisionsManager

packages/object/src/Charcoal/Object/RevisionService.php Outdated Show resolved Hide resolved
packages/object/src/Charcoal/Object/RevisionModelConfig.php Outdated Show resolved Hide resolved
packages/object/src/Charcoal/Object/RevisionModelConfig.php Outdated Show resolved Hide resolved
packages/object/src/Charcoal/Object/ObjectServiceProvider.php Outdated Show resolved Hide resolved
packages/object/src/Charcoal/Object/GenerateRevisionListener.php Show resolved Hide resolved
packages/object/src/Charcoal/Object/ObjectServiceProvider.php Outdated Show resolved Hide resolved
@JoelAlphonso JoelAlphonso merged commit e0301f6 into joel_feat_event-dispatcher Sep 30, 2022
@JoelAlphonso JoelAlphonso deleted the Joel_feat_revision-event branch September 30, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcaskill mcaskill Awaiting requested review from mcaskill

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoelAlphonso @mcaskill