Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for events, listeners, and dispatchers #64

Open
wants to merge 92 commits into
base: main
Choose a base branch
from
Open

Add support for events, listeners, and dispatchers #64

Show file tree
Hide file tree
Changes from 90 commits
Commits
Show all changes
92 commits
Select commit Hold shift + click to select a range
dbcd400
feat(app): add event dispatcher provided by `league/event`
JoelAlphonso Sep 9, 2022
af9de97
feat(app): add PropertyEvent for Property related events
JoelAlphonso Sep 9, 2022
35590ee
feat(app): add EventDispatcherTrait
JoelAlphonso Sep 9, 2022
0ba9b24
feat(property): (wip) add EventDispatcherTrait to AbstractProperty
JoelAlphonso Sep 9, 2022
243ae4d
docs(event): add event dispatcher documentation
JoelAlphonso Sep 12, 2022
2a9a401
feat(property-event): add data and fix event const for PropertyEvent
JoelAlphonso Sep 12, 2022
3ba8920
feat(property): dispatch events for `pre-save` and `save` event for I…
JoelAlphonso Sep 12, 2022
85ccf13
test(user): fix phpunit error due to missing composer['event/dispatch…
JoelAlphonso Sep 12, 2022
9bf2ac3
test(charcoal): fix phpunit error due to missing composer['event/disp…
JoelAlphonso Sep 12, 2022
001bb22
style(readme): prefix league packages links
JoelAlphonso Sep 12, 2022
c5c98e3
style(composer): order packages alphabetically
JoelAlphonso Sep 12, 2022
ec0a6b6
chore(app): remove unneeded import
JoelAlphonso Sep 12, 2022
53a8475
refactor(property): change `event` property to `type` property
JoelAlphonso Sep 12, 2022
a0918a8
fix(psr4): fix some namespacing issues
JoelAlphonso Sep 12, 2022
9b24e83
tests(property): run phpcbf on `property` package
JoelAlphonso Sep 12, 2022
52f0dc2
style(test): fix code style
JoelAlphonso Sep 13, 2022
1c31bbc
refactor(php): improve type hinting and argument typing of AppConfig …
JoelAlphonso Sep 14, 2022
59f3deb
feat(event): add an AbstractEventListener and EventListenerInterface
JoelAlphonso Sep 16, 2022
56ee444
feat(event): add a base event and a (wip) generic event
JoelAlphonso Sep 16, 2022
67cc23c
feat(event): add a charcoal EventDispatcher which extends League\Even…
JoelAlphonso Sep 16, 2022
c130dfa
refactor(event): move EventDispatcherTrait.php to the `event` namespace
JoelAlphonso Sep 16, 2022
4c42437
feat(event): Add an event service provider and improve listeners regi…
JoelAlphonso Sep 16, 2022
e49ff79
feat(event): add a FileWasUploaded event
JoelAlphonso Sep 16, 2022
ecc7180
feat(elfinder): dispatch FileWasUploaded on elfinder upload.presave
JoelAlphonso Sep 19, 2022
9dbe114
build(composer): update composer lock file
JoelAlphonso Sep 19, 2022
3d0ca30
tests(property): fix phpunit test
JoelAlphonso Sep 19, 2022
9ab5164
fix(translation-parser): fix paths related problems with translation-…
JoelAlphonso Sep 19, 2022
79bde11
feat(translation-parser): add translation-parser script tag to defaul…
JoelAlphonso Sep 19, 2022
0f741a1
refactor(event): rename `stopped` property
JoelAlphonso Sep 20, 2022
ce6d966
docs(event): improve class comment
JoelAlphonso Sep 20, 2022
610d589
refactor(app): improve readability in FilesystemServiceProviderTest.php
JoelAlphonso Sep 20, 2022
c9057bb
refactor(event): add a method to register event listeners in EventSer…
JoelAlphonso Sep 20, 2022
8618442
docs(event): add container comment in foreach loop
JoelAlphonso Sep 20, 2022
3c3a85e
refactor(event): force config defined listeners to be registered as a…
JoelAlphonso Sep 20, 2022
e1dd427
refactor(event-dispatcher): improve logging context
JoelAlphonso Sep 20, 2022
33c1943
style(event): fix typo
JoelAlphonso Sep 20, 2022
3b1f4ba
refactor(config): improve path readability
JoelAlphonso Sep 20, 2022
8784c14
feat(event): add support for ListenerSubscriber through config files …
JoelAlphonso Sep 20, 2022
4a010cf
refactor(event): move the event system to it's own package
JoelAlphonso Sep 20, 2022
3726788
fix(image-property): remove event dispatch for property for now
JoelAlphonso Sep 20, 2022
7e4b1c1
refactor(property): remove EventDispatcherTrait from AbstractProperty…
JoelAlphonso Sep 20, 2022
5d22f7c
fix(event): fix bad references to `event` package
JoelAlphonso Sep 20, 2022
b198240
tests(event): remove event related container dependencies for now
JoelAlphonso Sep 20, 2022
c8f98f7
build(composer): update composer lock file
JoelAlphonso Sep 20, 2022
bb2331c
tests(event): add placeholder test class to prevent test failure
JoelAlphonso Sep 21, 2022
99663a5
style: apply requested style changes by @mcaskill
JoelAlphonso Sep 21, 2022
09fe34a
fix(exception): fix missing sprintf context
JoelAlphonso Sep 21, 2022
4a9f26c
refactor(event): ensure setDependencies is callable
JoelAlphonso Sep 21, 2022
a7f5f88
docs(event): update `README.md` for the `Event` package
JoelAlphonso Sep 21, 2022
19fd328
feat(event): add events related to object
JoelAlphonso Sep 21, 2022
fc3180a
tests(phpunit): fix failed tests due to `event\dispatcher` container
JoelAlphonso Sep 21, 2022
d8c1e40
refactor(event): use a builder to build an admin scoped event dispatcher
JoelAlphonso Sep 22, 2022
56769d3
style: apply suggestions from code review
JoelAlphonso Sep 23, 2022
a887c73
feat(object): add an ObjectServiceProvider for object package services
JoelAlphonso Sep 26, 2022
5e37023
refactor(revision): refactor revision object and interface to use Mod…
JoelAlphonso Sep 26, 2022
dc17ab9
feat(revision): remove revision generation from Content.php
JoelAlphonso Sep 26, 2022
342c91f
feat(revision): add a revision service to handle all revision related…
JoelAlphonso Sep 26, 2022
448a780
feat(revision): add a listener to hook revision generation
JoelAlphonso Sep 26, 2022
8bffba8
feat(revision): add RevisionConfig.php to cast revisions config nodes to
JoelAlphonso Sep 26, 2022
205258c
feat(revision): add `properties` and `propertyBlacklist` options for …
JoelAlphonso Sep 26, 2022
8d84a4e
refactor(revision): refactor revision config and service to allow for…
JoelAlphonso Sep 27, 2022
8f2bd66
fix(revision): fix included properties and properties options
JoelAlphonso Sep 28, 2022
8eb4b41
feat(revision): use the revisions service everywhere and refactor it …
JoelAlphonso Sep 29, 2022
59845de
refactor(revisions): rename `RevisionService` to `RevisionsManager`
JoelAlphonso Sep 30, 2022
a191404
refactor(revisions): rename revisions config and container keys with …
JoelAlphonso Sep 30, 2022
d080744
refactor(revisions): rename `ObjectServiceProvider` to `RevisionServi…
JoelAlphonso Sep 30, 2022
3a83d57
refactor(revisions): fix method comments
JoelAlphonso Sep 30, 2022
019f2ea
refactor(revision): uniformize functions names for RevisionsManager
JoelAlphonso Nov 4, 2022
2277955
refactor(revision): remove unnecessary exception
JoelAlphonso Nov 4, 2022
3cce5e4
fix(revisions): fix remaining revisionService renaming
JoelAlphonso Sep 30, 2022
6915a21
refactor(event): add StoppableEventTrait and refactor Event with it
JoelAlphonso Nov 1, 2022
de71935
feat(event): add interruptable contract for events which provides eve…
JoelAlphonso Nov 1, 2022
2d6f132
refactor(event): move model related events to the `core` package
JoelAlphonso Nov 1, 2022
2e4db81
refactor(event): move model events dispatch from actions to StorableT…
JoelAlphonso Nov 1, 2022
7d7c47e
docs(revision): add some documentation for the reformed revision system
JoelAlphonso Nov 3, 2022
ad160f4
Apply suggestions from code review
JoelAlphonso Nov 4, 2022
5ad2122
feat(proxies): implement static proxies system using the facade model
JoelAlphonso Nov 1, 2022
2f13ddd
Apply suggestions from code review
JoelAlphonso Nov 3, 2022
bac3557
refactor(facade): improve facade terminology
JoelAlphonso Nov 3, 2022
7fa1eb0
Apply suggestions from code review
JoelAlphonso Nov 4, 2022
df78a3b
refactor(facade): make `facade` abstract
JoelAlphonso Nov 4, 2022
773938a
refactor(facade): use the container as resolver instead of the passin…
JoelAlphonso Nov 4, 2022
b48dd17
fix(event): fix missing renaming
JoelAlphonso Nov 8, 2022
eb3699b
fix(event): rename event services container keys to be prefixed with …
JoelAlphonso Nov 8, 2022
e1e57d3
chore(composer): update composer lock file
JoelAlphonso Nov 8, 2022
4e3eecd
tests(app): fixing phpunit tests failures caused be refactoring revis…
JoelAlphonso Nov 11, 2022
d20153e
chore(composer): update composer lock file
JoelAlphonso Nov 11, 2022
cc2d8c8
tests(event): add test placeholder
JoelAlphonso Nov 11, 2022
7343fbd
refactor(facade): Improve type-hinting
mcaskill Nov 12, 2022
ff5e12e
refactor(elfinder): Improve FileWasUploaded integration
mcaskill Nov 12, 2022
8f99c4a
Remove unused PHP imports
mcaskill Nov 18, 2022
310eb8b
Rename parameter name in RevisionServiceProvider
mcaskill Nov 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
"kriswallsmith/assetic": "^1.4",
"laminas/laminas-permissions-acl": "^2.8",
"league/climate": "^3.2",
"league/event": "^3.0",
"league/flysystem": "^1.0",
"mcaskill/php-html-build-attributes": "^1.0",
"monolog/monolog": "^1.17",
Expand Down Expand Up @@ -95,6 +96,7 @@
],
"Charcoal\\Admin\\": "packages/admin/src/Charcoal/Admin/",
"Charcoal\\Email\\": "packages/email/src/Charcoal/Email",
"Charcoal\\Event\\": "packages/event/src/Charcoal/Event/",
"Charcoal\\Object\\": "packages/object/src/Charcoal/Object",
"Charcoal\\User\\": "packages/user/src/Charcoal/User",
"Charcoal\\View\\": "packages/view/src/Charcoal/View"
Expand All @@ -114,6 +116,7 @@
"packages/config/tests/Charcoal/",
"packages/core/tests/Charcoal",
"packages/email/tests/Charcoal",
"packages/event/tests/Charcoal",
"packages/factory/tests/Charcoal/",
"packages/image/tests/Charcoal",
"packages/object/tests/Charcoal/",
Expand All @@ -135,6 +138,7 @@
"charcoal/config": "self.version",
"charcoal/core": "self.version",
"charcoal/email": "self.version",
"charcoal/event": "3.1.8",
"charcoal/factory": "self.version",
"charcoal/image": "self.version",
"charcoal/object": "self.version",
Expand Down
Loading