Fix PHPUnit tests across all packages #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelAlphonso
force-pushed
the
joel_test-suite
branch
from
ce9b0e0
to
4f74d40
Compare
mcaskill
changed the title
mcaskill
requested changes
Sep 8, 2022
There was a problem hiding this comment.
Looks good as far as I can see from skimming most files.
There's some checks that will need to be resolved, I think, though I have not consulted them all. Some suggestions for the PHPCS script will improve CI formatting for humans to read.
Repository-wide suggestions:
- The opening brace for the methods must go on its own line.
- protected function setUp(): void { + protected function setUp(): void + {
- Rename
tests/scriptdirectory totests/scripts.
…ulted to an empty string like in ViewableTrait.php
Co-authored-by: Chauncey McAskill <[email protected]>
Co-authored-by: Chauncey McAskill <[email protected]>
… attributes Co-authored-by: Chauncey McAskill <[email protected]>
Co-authored-by: Chauncey McAskill <[email protected]>
Co-authored-by: Chauncey McAskill <[email protected]>
Co-authored-by: Chauncey McAskill <[email protected]>
Co-authored-by: Chauncey McAskill <[email protected]>
Co-authored-by: Chauncey McAskill <[email protected]>
Co-authored-by: Chauncey McAskill <[email protected]>
JoelAlphonso
force-pushed
the
joel_test-suite
branch
from
d79de25
to
3b42ff0
Compare
mcaskill
approved these changes
Sep 8, 2022
|
🎉 This PR is included in version 3.1.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PHPUnit tests across all packages with the option to run tests from the monorepo package (either all packages at once or individually) or run tests from each package if their dependencies are installed.
Changes :
Bug Fixes