Support --gpus-per-node as a CLI argument and in slurm-gasnetrun* launchers
#26166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jade Abraham <[email protected]>
jabraham17
force-pushed
the
add-missing-gpus-per-node
branch
from
7a0253f
to
87137a4
Compare
e-kayrakli
approved these changes
Oct 29, 2024
Signed-off-by: Jade Abraham <[email protected]>
Signed-off-by: Jade Abraham <[email protected]>
jhh67
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands the work done in #24608 to support
--gpus-per-nodeboth as a CLI argument to theslurm-srunlauncher and to add it as an option forslurm-gasnetrun*launchers.Prior to this PR, users could only specify
CHPL_LAUNCHER_GPUS_PER_NODEas an environment variable, and this variable was not respected by all slurm based launchers.Note: This PR adds the CLI argument as this is a key slurm argument that some systems need. This also makes gpus feel more like a first-class Chapel feature for slurm based launchers.
Testing:
CHPL_LAUNCHER=slurm-srunCHPL_LAUNCHER=slurm-gasnetrun_ibv[Reviewed by @e-kayrakli and @jhh67]