Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve basic associative domains with module code in Dyno #26077

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from
Draft

Resolve basic associative domains with module code in Dyno #26077

wants to merge 19 commits into from

Commits on Oct 31, 2024

  1. Fix followThis type in ChapelHashtable._allSlots follower 

    Signed-off-by: Anna Rift <[email protected]>
    @riftEmber
    riftEmber committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    37f1dd2 View commit details
    Browse the repository at this point in the history

  2. Initial fix for return in param for 

    Signed-off-by: Anna Rift <[email protected]>
    @riftEmber
    riftEmber committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    f9f6d4e View commit details
    Browse the repository at this point in the history

  3. Correct comment on skipping non-param loops 

    Signed-off-by: Anna Rift <[email protected]>
    @riftEmber
    riftEmber committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    aa9943f View commit details
    Browse the repository at this point in the history

  4. Add some test cases 

    Signed-off-by: Anna Rift <[email protected]>
    @riftEmber
    riftEmber committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    0a4bc81 View commit details
    Browse the repository at this point in the history

  5. Add basic break/continue test cases 

    Signed-off-by: Anna Rift <[email protected]>
    @riftEmber
    riftEmber committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    48cde82 View commit details
    Browse the repository at this point in the history

  6. Add conditional break/continue test cases 

    Signed-off-by: Anna Rift <[email protected]>
    @riftEmber
    riftEmber committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    b921002 View commit details
    Browse the repository at this point in the history

  7. Get conditional break and continue working 

    Signed-off-by: Anna Rift <[email protected]>
    @riftEmber
    riftEmber committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    50018cb View commit details
    Browse the repository at this point in the history

  8. Add test that non-param loop stil fails 

    Signed-off-by: Anna Rift <[email protected]>
    @riftEmber
    riftEmber committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    c4a3f40 View commit details
    Browse the repository at this point in the history

  9. Fix skipping non-param loop traversal 

    Signed-off-by: Anna Rift <[email protected]>
    @riftEmber
    riftEmber committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    0e11eae View commit details
    Browse the repository at this point in the history

  10. Slightly refactor subframe info gathering 

    Signed-off-by: Anna Rift <[email protected]>
    @riftEmber
    riftEmber committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    5f7593b View commit details
    Browse the repository at this point in the history

  11. Inline markBreak and markContinue functions 

    Signed-off-by: Anna Rift <[email protected]>
    @riftEmber
    riftEmber committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    605ac47 View commit details
    Browse the repository at this point in the history

  12. Remove unused commented helper 

    Signed-off-by: Anna Rift <[email protected]>
    @riftEmber
    riftEmber committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    c702868 View commit details
    Browse the repository at this point in the history

  13. Fix formal name typo 

    Signed-off-by: Anna Rift <[email protected]>
    @riftEmber
    riftEmber committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    77fa65d View commit details
    Browse the repository at this point in the history

  14. Clarify loop body skipping comment 

    Signed-off-by: Anna Rift <[email protected]>
    @riftEmber
    riftEmber committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    5dec0fe View commit details
    Browse the repository at this point in the history

  15. Clarify new assert message 

    Signed-off-by: Anna Rift <[email protected]>
    @riftEmber
    riftEmber committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    f7aeb4d View commit details
    Browse the repository at this point in the history

  16. Test different returns in different iterations 

    Signed-off-by: Anna Rift <[email protected]>
    @riftEmber
    riftEmber committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    7ec5119 View commit details
    Browse the repository at this point in the history

  17. Refactor tests to use helper 

    Signed-off-by: Anna Rift <[email protected]>
    @riftEmber
    riftEmber committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    41db4f1 View commit details
    Browse the repository at this point in the history

  18. Add TODO for better return type errors 

    Signed-off-by: Anna Rift <[email protected]>
    @riftEmber
    riftEmber committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    27f02b4 View commit details
    Browse the repository at this point in the history

  19. Remove collectGarbage calls in testDomains for speed 

    Signed-off-by: Anna Rift <[email protected]>
    @riftEmber
    riftEmber committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    87170da View commit details
    Browse the repository at this point in the history