Require setupModuleSearchPaths be called before any other queries
#25315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like something in |
mppf
approved these changes
Jun 18, 2024
|
@DanilaFe how do I reproduce failures from that? I built with |
|
Nvm, I see the CI failure from |
riftEmber
force-pushed
the
modulesearchpath-init
branch
from
610a04f
to
5bfd74d
Compare
DanilaFe
reviewed
Jun 19, 2024
|
@riftEmber if this PR has user-facing outcomes, could you please mention them in the OP? |
|
@vasslitvinov Yes, good reminder. Updated |
riftEmber
force-pushed
the
modulesearchpath-init
branch
2 times, most recently
from
8b2f052
to
b319e2c
Compare
riftEmber
force-pushed
the
modulesearchpath-init
branch
2 times, most recently
from
49cb543
to
3859261
Compare
DanilaFe
approved these changes
Jun 20, 2024
This builds on files_with_contexts to get contexts with stdlib. Signed-off-by: Danila Fedorin <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
This reverts commit 1ffa868. Signed-off-by: Anna Rift <[email protected]>
From chapel-lang#25326 Signed-off-by: Anna Rift <[email protected]>
Signed-off-by: Anna Rift <[email protected]>
riftEmber
force-pushed
the
modulesearchpath-init
branch
from
3859261
to
fa1cd8a
Compare
riftEmber
added a commit
that referenced
this pull request
Jul 3, 2024
Resolve tuple `this` calls (with non-param index values) in Dyno. This is implemented by wiring up Dyno's `TupleType` to `ChapelTuple._tuple` in the bundled modules. The module implementation of `_tuple.size` (called by `this`) is technically used but its param value is computed by dyno, since in production it is only set later during generic instantiation. Depends on: #25007, #25102, #25231, #25315. Resolves Cray/chapel-private#6104. [reviewed by @dlongnecke-cray , thanks!] Testing: - [x] dyno tests - [x] paratest - [x] reproducer from backing issue now resolves
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require that setting the module search path occurs before any other queries in the Context revision, if at all. This is to prevent unexpected results from its default empty value being used before it is set, as many queries rely on it. Implemented as an assertion that it is the first query run in the revision.
Also change
testInteractiveto setup module search path earlier to be in line with this requirement. This fixes buggy behavior withtestInteractive --std, in which we might not find standard module types, that was incidentally introduced in #25190.Depends on #25326 which should be merged first.
[reviewer info placeholder]
Testing:
testInteractivewith basic programchpl --dynowith basic program