LSP: add call inlays for complex literals #25202
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25115.
This just involves adding some smarter AST inspection to detect what we want to treat like "literals" for the purposes of call inlays. Specifically, I've opted for the following:
1+1
is not a literal, neither is1 + 1i + 1
. On the other hand,1 + 1i
is a literal.1 + 1i
or1i + 1
. This is a bit liberal, but I think it's reasonable.-4
is a "literal", but- -4
is not.4 - (-i)
is not a literal.I've un-xfailed the test that locked this down, and added a separate test for negative numbers.
Reviewed by @jabraham17 -- thanks!
Testing
make test-cls