Fix mason license source #25062
Merged
Fix mason license source #25062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arezaii
force-pushed
the
fix-mason-license-source
branch
from
ca6cf1c
to
6693af0
Compare
benharsh
reviewed
May 20, 2024
arezaii
force-pushed
the
fix-mason-license-source
branch
from
b33d0a4
to
198ca5c
Compare
Signed-off-by: arezaii <[email protected]>
Signed-off-by: arezaii <[email protected]>
Signed-off-by: arezaii <[email protected]>
arezaii
force-pushed
the
fix-mason-license-source
branch
from
198ca5c
to
1d58b16
Compare
Signed-off-by: Ahmad Rezaii <[email protected]>
arezaii
force-pushed
the
fix-mason-license-source
branch
from
1d58b16
to
eeb8c69
Compare
benharsh
approved these changes
May 22, 2024
| const badSyntaxMessage = 'Arguments do not follow "mason publish [options] <registry>" syntax'; | ||
|
|
||
| if refreshLicenses { | ||
| writeln("Force updating list of valid license names from SPDX repo..."); |
There was a problem hiding this comment.
Would a hyphen be appropriate here? "Force-updating"? I'm not 100% sure of my grammar here (or anywhere...).
At your discretion.
tools/mason/MasonPublish.chpl
Outdated
| if refreshLicenses { | ||
| writeln("Force updating list of valid license names from SPDX repo..."); | ||
| refreshLicenseList(true); | ||
| writeln("done updating license list"); |
There was a problem hiding this comment.
After grepping around, it looks like we tend to use capitalization for the first word.
Signed-off-by: Ahmad Rezaii <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Mason, updates the source list of valid license names to the proper spdx repository. Also adds a new option to
mason publish,--refresh-licensesthat will force delete and make a new clone of the license repository that is stored in the.masonfolder.The feature is implemented in such a way that if it's passed, it will be the only option executed. This felt OK to me since it should be a very rarely if ever used option and it seemed like a distinct operation from the publishing actions.
Includes some testing for the refresh-licenses feature, while there, updated some tests that had malformed arguments to the corresponding
masonsub-function, and fixed some linter warnings for unused names and indentation.TESTING:
[Summary: #Successes = 17229 | #Failures = 0 | #Futures = 926][reviewed by @benharsh - thanks!]