Fix tasks without required SortingHat client #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tasks that didn’t require the SortingHat client were failing or receiving incorrect arguments because the client was being passed as the second argument. Since the client is required for all tasks, it has been added as an argument in the subclass constructors. Signed-off-by: Jose Javier Merchante <[email protected]>
jjmerchante
force-pushed
the
fix-tasks
branch
from
3a33c79
to
f55f6da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks that didn’t require the SortingHat client were failing or receiving incorrect arguments because the client was being passed as the second argument. Since the client is required for all tasks, it has been added as an argument in the subclass constructors.