Include missing parameters in enrich task #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 6479115951
💛 - Coveralls |
jjmerchante
force-pushed
the
fix-sh-params
branch
from
532a7ff
to
b14ab6b
Compare
sduenas
requested changes
Oct 10, 2023
| @@ -0,0 +1,8 @@ | |||
| --- | |||
| title: Missing parameters for SortingHat | |||
There was a problem hiding this comment.
Suggested change
| title: Missing parameters for SortingHat | |
| title: Missing database parameters for SortingHat |
| author: null | ||
| issue: null | ||
| notes: > | ||
| Include missing SortingHat parameters during the initialization of |
There was a problem hiding this comment.
Suggested change
| Include missing SortingHat parameters during the initialization of | |
| SortingHat database parameters were not included during the initialization of |
There are some SortingHat parameters that weren't included when starting the enrich_backend. This was not raising any error because the backend was initialized in the load_identities method, but if that method is skipped, the enrich backend process fails. Signed-off-by: Jose Javier Merchante <[email protected]>
jjmerchante
force-pushed
the
fix-sh-params
branch
from
b14ab6b
to
0262e7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some SortingHat parameters that weren't included when starting the enrich_backend. This was not raising any error because the backend was initialized in the load_identities method, but if that method is skipped, the enrich backend process fails.