-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: mirror-data-to-staging-on-deploy #6044
base: main
Are you sure you want to change the base?
Conversation
runs upstream of post-deployment tests
Deployment Summary
|
Codecov Report
@@ Coverage Diff @@
## main #6044 +/- ##
==========================================
+ Coverage 85.84% 90.89% +5.04%
==========================================
Files 196 169 -27
Lines 15410 13834 -1576
==========================================
- Hits 13229 12574 -655
+ Misses 2181 1260 -921
Flags with carried forward coverage won't be shown. Click here to find out more. see 74 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
The existing scripts are not usable without major changes, due to differences in how IAM roles are assumed in local usage vs GHA usage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
- To be extra safe, might it be worthwhile to take a manual backup of prod data before running this?
- And maybe even have a script ready to update
prod
with the backup in case something does go wrong? (maybe this is over-cautious)
I'l do 1 for sure, and I'll create an RDS snapshot as well. |
This is not a viable design, due to GHA being outside of VPC! Will replace with a proper design.
Reason for Change
Changes
Testing steps
Notes for Reviewer