Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add clarifying back-merge instruction #2080

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

booc0mtaco
Copy link
Contributor

Adding a git pull to grab the latest on next before attempting to back-merge, so that the push isn't rejected unnecessarily. Makes collaboration a little smoother :)

Without that, if any PRs land on next before a release is completed, it can cause some merge noise and a little off-script actions that can leave the repository in an ambiguous state.

Test Plan:

  • Wrote/updated automated tests
  • CI tests / new tests are not applicable
  • Manually tested my changes, and here are the details:

@booc0mtaco booc0mtaco requested a review from a team October 21, 2024 22:44
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.10%. Comparing base (b5b8184) to head (ed13718).

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2080   +/-   ##
=======================================
  Coverage   97.10%   97.10%           
=======================================
  Files         111      111           
  Lines        2766     2766           
  Branches      738      738           
=======================================
  Hits         2686     2686           
  Misses         77       77           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

size-limit report 📦

Path Size
components 92.69 KB (0%)
styles 28.82 KB (0%)

@booc0mtaco booc0mtaco merged commit 299d074 into next Oct 22, 2024
12 checks passed
@booc0mtaco booc0mtaco deleted the aholloway/EFI-2092 branch October 22, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants