This repository has been archived by the owner on Jun 5, 2024. It is now read-only.
Add global expanded APK cache #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This dedupes fetching and expansion of APKs to avoid simultaneous builds doing a lot of duplicate expensive work. As a bonus, we also deduplicate indexing an APK's tar headers so we do it once per APK per process instead of every time we open an APK. The caching mechanisms that already existed are very useful for cache hits on subsequent builds, but there was still some overhead loading things from disk per cache hit. We avoid most of that now. There was also no coordination across builds when fetching indexes, keys, and APKs. Now, we should only fetch or load any given thing one time, which will reduce the number of requests we send out to the internet but also a lot of CPU in gunzip and untar. Signed-off-by: Jon Johnson <[email protected]>
|
Tested all three new caches out with the terraform provider on a small set of chainguard-images: With a warm apko cache, this is not that significant because we spend so much time ing zip, but we do drop from 21s to 20s. With a cold apko cache (which is what our CI will see), I I saw overall time drop from 36s to 27s. Mostly, that's time not spent waiting on HTTP HEAD requests to come back. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This dedupes fetching and expansion of APKs to avoid simultaneous builds doing a lot of duplicate expensive work. As a bonus, we also deduplicate indexing an APK's tar headers so we do it once per APK per process instead of every time we open an APK.
The caching mechanisms that already existed are very useful for cache hits on subsequent builds, but there was still some overhead loading things from disk per cache hit. We avoid most of that now. There was also no coordination across builds when fetching indexes, keys, and APKs. Now, we should only fetch or load any given thing one time, which will reduce the number of requests we send out to the internet but also a lot of CPU in gunzip and untar.