feat: track balance increases in state diffs #745
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thedevbirb
force-pushed
the
lore/feat/preconfirmed-balance
branch
2 times, most recently
from
d90940f to
103f836
Compare
thedevbirb
added
C: bolt-sidecar
This map can be read, just know that it contains the canonical account state at the head of the block.
thedevbirb
force-pushed
the
lore/feat/preconfirmed-balance
branch
from
103f836 to
54cb18b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces chained preconfirmations from different users in the sidecar. Example:
In order to do that the state diffs logic has been slightly modified by tracking both balance increases and decreases. Some refactoring has been done to avoid opaque tuple types and improve readability. Comes with tests included.
I strongly suggest to read the PR commit by commit, where some of them carry their own description and rationale.