Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: ES6 Upgrade (fixes: issue/13) #32

Open
wants to merge 74 commits into
base: master
Choose a base branch
from
Open

Conversation

joe-replin
Copy link
Contributor

@joe-replin joe-replin commented Sep 26, 2024

Fix

Update

  • README, Bower & Package updates.
  • All JS files to ES6 standards.
  • Removed Polyfill Libraries
  • Removed Favorite & Unfavorite Statement Models.
  • Parent Preffered file with languagePicker and visua11y as children of preferred statement file.

Breaking

  • Requires 5.19.1 of Adapt due to dependencies.

Testing

  1. Install plug-in to new instance of FW.
  2. Set authorization details appropriately in launch.html
  3. Disable adapt-contrib-spoor
  4. Run down the list, testing each available config option & xAPI statement as listed.

@danielghost
Copy link
Contributor

danielghost commented Oct 2, 2024

Before doing a proper review of this, would it make sense to split this into 2 PRs, one for the ES6 conversion and then once approved a second for the new functionality?

It looks like the changes made to AbstractStatementModel is missing from this PR.

Arrow function already binds 'this' to the function.
Notify API
Optional Chaining
Template Literals
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove polyfill libraries es6 upgrade
3 participants