Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: aria-expanded attribute added to navigation button (#96) #98

Merged
merged 4 commits into from
Sep 11, 2023
Merged

Fix: aria-expanded attribute added to navigation button (#96) #98

merged 4 commits into from
Sep 11, 2023

Conversation

joe-allen-89
Copy link
Contributor

#96

Fix

@joe-allen-89 joe-allen-89 added bug Something isn't working accessibility labels Sep 6, 2023
@joe-allen-89 joe-allen-89 self-assigned this Sep 6, 2023
@joe-allen-89 joe-allen-89 linked an issue Sep 6, 2023 that may be closed by this pull request
Set aria-expanded attribute to match drawer/notify visibility #96
Closed
kirsty-hames
kirsty-hames reviewed Sep 6, 2023
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up @joe-allen-89.

When _location is set to notify this works as expected. When the _location is set to drawer however the aria-expanded remains true when drawer is collapsed.

@joe-allen-89
Copy link
Contributor Author

joe-allen-89 commented Sep 7, 2023 •
edited
Loading

Thanks for picking this up @joe-allen-89.

When _location is set to notify this works as expected. When the _location is set to drawer however the aria-expanded remains true when drawer is collapsed.

@kirsty-hames Apologies, stupidly missed off the event listener for drawer:closed.

I've added that in and moved all event listeners to their own function to keep code clean.

@oliverfoster oliverfoster merged commit 5e0c1e9 into master Sep 11, 2023
@oliverfoster oliverfoster deleted the issue/96 branch September 11, 2023 08:36
github-actions bot pushed a commit that referenced this pull request Sep 11, 2023
@semantic-release-bot
Chore(release): 2.5.2 [skip ci]
cc6fe2a 
## [2.5.2](v2.5.1...v2.5.2) (2023-09-11)

### Fix

* aria-expanded attribute added to navigation button (#96) (#98) ([5e0c1e9](5e0c1e9)), closes [#96](#96) [#98](#98)
@github-actions
Copy link

🎉 This PR is included in version 2.5.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirsty-hames kirsty-hames kirsty-hames left review comments

Assignees

@joe-allen-89 joe-allen-89

Labels
accessibility bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set aria-expanded attribute to match drawer/notify visibility
3 participants
@joe-allen-89 @kirsty-hames @oliverfoster