Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: remove text-shadow + box-shadow when 'No Transparency' enabled (fixes #73) #113

Merged
merged 5 commits into from
Apr 16, 2024
Merged

Update: remove text-shadow + box-shadow when 'No Transparency' enabled (fixes #73) #113

merged 5 commits into from
Apr 16, 2024

Conversation

kirsty-hames
Copy link
Contributor

Fixes #73

Update

  • When 'No Transparency' is enabled, remove box-shadow styles containing transparency. Meaning, where box-shadow has an offset and/or blur value, to create a drop shadow effect for example. A zero offset and blur displays as a solid border (no transparency) so there's no reason to remove this. Quite often box-shadow is used in favour of border or outline as it offers more flexibility styling.

New

  • When 'No Transparency' enabled, remove text-shadow styles.

Testing

  1. Install Visua11y. Copy the example config into course.json and enable.
  2. Add some box-shadow and text-shadow styles to your theme. For example:
.page__title {
  text-shadow: red 2px 5px;
}
.hotgraphic__pin {
  box-shadow: 10px 5px 5px red;
}
  1. Confirm styles have been applied in your course.
  2. Enable 'No Transparency' in Visually settings.
  3. Review course to confirm styles have been removed.

@kirsty-hames kirsty-hames self-assigned this Apr 16, 2024
@kirsty-hames kirsty-hames added the enhancement New feature or request label Apr 16, 2024
@kirsty-hames
merge pull/112 (#114)
855b860 
* Update: remove legacy nav btn float (fixes #111) #112

* Chore(release): 2.9.0 [skip ci]

# [2.9.0](v2.8.2...v2.9.0) (2024-03-18)

### Chore

* Update releases.yml to v3 ([f952a65](f952a65))

### Update

* remove legacy nav btn float (fixes #111) #112 ([4a0d41f](4a0d41f)), closes [#111](#111) [#112](#112)
@kirsty-hames kirsty-hames merged commit 2553ec4 into master Apr 16, 2024
github-actions bot pushed a commit that referenced this pull request Apr 16, 2024
@semantic-release-bot
Chore(release): 2.10.0 [skip ci]
0d9089d 
# [2.10.0](v2.9.0...v2.10.0) (2024-04-16)

### Update

* remove text-shadow + box-shadow when 'No Transparency' enabled (fixes #73) (#113) ([2553ec4](2553ec4)), closes [#73](#73) [#113](#113)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 2.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@kirsty-hames kirsty-hames deleted the issue/73 branch April 16, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverfoster oliverfoster oliverfoster approved these changes

Assignees

@kirsty-hames kirsty-hames

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

text-shadow + box-shadow support
2 participants
@kirsty-hames @oliverfoster