Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Title is required to set notify popup dialog label (fixes #107) #108

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Fix: Title is required to set notify popup dialog label (fixes #107) #108

merged 2 commits into from
Jan 30, 2024

Conversation

kirsty-hames
Copy link
Contributor

Fixes #107

Fix

  • Set title as required. Without a title, the popup dialog won't be properly identified by assistive technologies.

@kirsty-hames kirsty-hames self-assigned this Jan 29, 2024
guywillis
guywillis approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@guywillis guywillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@oliverfoster oliverfoster merged commit 8a57e3c into master Jan 30, 2024
1 check passed
@oliverfoster oliverfoster deleted the issue/107 branch January 30, 2024 09:36
github-actions bot pushed a commit that referenced this pull request Jan 30, 2024
@semantic-release-bot
Chore(release): 2.8.1 [skip ci]
071bff9 
## [2.8.1](v2.8.0...v2.8.1) (2024-01-30)

### Fix

* Title is required to set notify popup dialog label (fixes #107) (#108) ([8a57e3c](8a57e3c)), closes [#107](#107) [#108](#108)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 2.8.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guywillis guywillis guywillis approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

Assignees

@kirsty-hames kirsty-hames

Labels
accessibility released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Title is required to set notify popup dialog label
3 participants
@kirsty-hames @oliverfoster @guywillis