Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create cubemap from file #93

Merged
merged 56 commits into from
May 18, 2021
Merged

Create cubemap from file #93

merged 56 commits into from
May 18, 2021

Commits on Nov 25, 2020

  1. partial implementation of cubemap support

    @stf976
    stf976 committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    c0c07af View commit details
    Browse the repository at this point in the history

  2. finish first working draft of cubemap texture support, 

    including example application
    @stf976
    stf976 committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    a819e2f View commit details
    Browse the repository at this point in the history

  3. in texture_cubemap example, transform left-handed cubemap coordinates… 

    … to right-handed world space

and vice versa using modelView matrices instead of in shader code;
add comments explaining coordinate system transformations
    @stf976
    stf976 committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    6cbbb05 View commit details
    Browse the repository at this point in the history

  4. first (incomplete) draft for loading cubemap from six individual files

    @stf976
    stf976 committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    b451822 View commit details
    Browse the repository at this point in the history

  5. adapt texture_cubemap example and load_cubemap_from_file after rebasi… 

    …ng branch on current master
    @stf976
    stf976 committed Nov 25, 2020
    Configuration menu
    Copy the full SHA
    6fe145f View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2020

  1. add image_resource_t helper class for image loading library abstraction; 

    implement image_resource_t classes for GLI and stb_image loaders;
add factory method create_image_resource_from_file();
implement composite_cubemap_image_resource_t class for creating cubemap from individual files;
update texture_cubemap example
    @stf976
    stf976 committed Nov 27, 2020
    Configuration menu
    Copy the full SHA
    82101f3 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2021

  1. partial implementation of cubemap support

    @stf976
    stf976 committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    726afae View commit details
    Browse the repository at this point in the history

  2. finish first working draft of cubemap texture support, 

    including example application
    @stf976
    stf976 committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    e5ae27f View commit details
    Browse the repository at this point in the history

  3. in texture_cubemap example, transform left-handed cubemap coordinates… 

    … to right-handed world space

and vice versa using modelView matrices instead of in shader code;
add comments explaining coordinate system transformations
    @stf976
    stf976 committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    e22b572 View commit details
    Browse the repository at this point in the history

  4. first (incomplete) draft for loading cubemap from six individual files

    @stf976
    stf976 committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    35c2520 View commit details
    Browse the repository at this point in the history

  5. adapt texture_cubemap example and load_cubemap_from_file after rebasi… 

    …ng branch on current master
    @stf976
    stf976 committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    7cdcfe7 View commit details
    Browse the repository at this point in the history

  6. add image_resource_t helper class for image loading library abstraction; 

    implement image_resource_t classes for GLI and stb_image loaders;
add factory method create_image_resource_from_file();
implement composite_cubemap_image_resource_t class for creating cubemap from individual files;
update texture_cubemap example
    @stf976
    stf976 committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    f0d3dd6 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2021

  1. add cubemap sample texture in ktx and dds format 

    add links to source
    @stf976
    stf976 committed Feb 27, 2021
    Configuration menu
    Copy the full SHA
    4bdd96f View commit details
    Browse the repository at this point in the history

  2. implement image_resource as bridge pattern to facilitate caching 

    simplify image_resource interfaces
fix screen resizing in texture_cubemap example after update
add caching to texture_cubemap example
add loading of dds texture to texture_cubemap example
    @stf976
    stf976 committed Feb 27, 2021
    Configuration menu
    Copy the full SHA
    8ab4b4b View commit details
    Browse the repository at this point in the history

  3. update revision of auto_vk

    @stf976
    stf976 committed Feb 27, 2021
    Configuration menu
    Copy the full SHA
    17491e3 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'create_cubemap_from_file' of https://github.com/cg-tuwi… 

    …en/Gears-Vk into create_cubemap_from_file
    @stf976
    stf976 committed Feb 27, 2021
    Configuration menu
    Copy the full SHA
    b3be9df View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2021

  1. add license information about yokohama_at_night textures

    @stf976
    stf976 committed Mar 20, 2021
    Configuration menu
    Copy the full SHA
    b08d507 View commit details
    Browse the repository at this point in the history

  2. remove commented-out code

    @stf976
    stf976 committed Mar 20, 2021
    Configuration menu
    Copy the full SHA
    5e05a02 View commit details
    Browse the repository at this point in the history

  3. follow naming conventions 

    Co-authored-by: Johannes Unterguggenberger <[email protected]>
    @stf976 @johannesugb
    stf976 and johannesugb authored Mar 20, 2021
    Configuration menu
    Copy the full SHA
    4b8155b View commit details
    Browse the repository at this point in the history

  4. rename sRGB, HDR parameters

    @stf976
    stf976 committed Mar 20, 2021
    Configuration menu
    Copy the full SHA
    cd86eb4 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2021

  1. add virtual constructor to image_resource_t 

    make conversion constructors of image_resource_base_t explicit
make variables and parameters const and auto if possible
prevent variable use after std::move
    @stf976
    stf976 committed Mar 21, 2021
    Configuration menu
    Copy the full SHA
    1c6d867 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'create_cubemap_from_file' of https://github.com/cg-tuwi… 

    …en/Gears-Vk into create_cubemap_from_file
    @stf976
    stf976 committed Mar 21, 2021
    Configuration menu
    Copy the full SHA
    43607a5 View commit details
    Browse the repository at this point in the history

  3. delete special functions for image_resource_base_t 

    make conversion constructors explicit for image_resource_t classes
    @stf976
    stf976 committed Mar 21, 2021
    Configuration menu
    Copy the full SHA
    278fd60 View commit details
    Browse the repository at this point in the history

  4. follow naming conventions 

    Co-authored-by: Johannes Unterguggenberger <[email protected]>
    @stf976 @johannesugb
    stf976 and johannesugb authored Mar 21, 2021
    Configuration menu
    Copy the full SHA
    8f0d4ca View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    follow naming conventions
use gvk::owned instead of std::move

Co-authored-by: Johannes Unterguggenberger <[email protected]>
    @stf976 @johannesugb
    stf976 and johannesugb authored Mar 21, 2021
    Configuration menu
    Copy the full SHA
    2d601bf View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2021

  1. use avk::resource_reference for type of image_resource instead of std… 

    …::unique_ptr, adapt code accordingly

add create_image_resource() helper functions
fix compilation errors in texture_cubemap example
    @stf976
    stf976 committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    41cebe9 View commit details
    Browse the repository at this point in the history

  2. use avk::owning_resource for type of image_resource instead of std::u… 

    …nique_ptr, adapt code accordingly

add create_image_resource() helper functions
fix compilation errors in texture_cubemap example
    @stf976
    stf976 committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    8a4cf47 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'create_cubemap_from_file' of https://github.com/cg-tuwi… 

    …en/Gears-Vk into create_cubemap_from_file
    @stf976
    stf976 committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    d0e8fb1 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2021

  1. add explanation of memory, resource leaks for [[nodiscard]] to guidel… 

    …ines
    @stf976
    stf976 committed Mar 28, 2021
    Configuration menu
    Copy the full SHA
    cff294d View commit details
    Browse the repository at this point in the history

  2. add image_resource.hpp to gvk.hpp

    @stf976
    stf976 committed Mar 28, 2021
    Configuration menu
    Copy the full SHA
    6e95f0f View commit details
    Browse the repository at this point in the history

  3. don't create image_resource explicitly in cubemap example, use create… 

    …_cubemap_from_file_cached instead
    @stf976
    stf976 committed Mar 28, 2021
    Configuration menu
    Copy the full SHA
    4a298f6 View commit details
    Browse the repository at this point in the history

  4. rename image_resource* types and files to image_data* 

    remove old duplicate file
    @stf976
    stf976 committed Mar 28, 2021
    Configuration menu
    Copy the full SHA
    54ac8ef View commit details
    Browse the repository at this point in the history

  5. Revert "add explanation of memory, resource leaks for [[nodiscard]] t… 

    …o guidelines"
    @stf976
    stf976 committed Mar 28, 2021
    Configuration menu
    Copy the full SHA
    3a4a68a View commit details
    Browse the repository at this point in the history

  6. rename image_resource* types to image_data*

    @stf976
    stf976 committed Mar 28, 2021
    Configuration menu
    Copy the full SHA
    92a20e9 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2021

  1. code cleanup in cubemap_texture example 

    Co-authored-by: Johannes Unterguggenberger <[email protected]>
    @stf976 @johannesugb
    stf976 and johannesugb authored Apr 25, 2021
    Configuration menu
    Copy the full SHA
    9a5b1b4 View commit details
    Browse the repository at this point in the history

  2. remove initialization of removed mInitTime variable

    @stf976
    stf976 committed Apr 25, 2021
    Configuration menu
    Copy the full SHA
    edad486 View commit details
    Browse the repository at this point in the history

  3. use consistent parameter names, camel case 

    Co-authored-by: Johannes Unterguggenberger <[email protected]>
    @stf976 @johannesugb
    stf976 and johannesugb authored Apr 25, 2021
    Configuration menu
    Copy the full SHA
    357b886 View commit details
    Browse the repository at this point in the history

  4. use consistent variable names

    @stf976
    stf976 committed Apr 25, 2021
    Configuration menu
    Copy the full SHA
    9efcfc1 View commit details
    Browse the repository at this point in the history

  5. use create_vertex_and_index_buffers, create_normals_buffer for model … 

    …loading in texture_cubemap example
    @stf976
    stf976 committed Apr 25, 2021
    Configuration menu
    Copy the full SHA
    7cead62 View commit details
    Browse the repository at this point in the history

  6. remove owning_resource wrapper from image_data 

    Co-authored-by: Johannes Unterguggenberger <[email protected]>
    @stf976 @johannesugb
    stf976 and johannesugb authored Apr 25, 2021
    Configuration menu
    Copy the full SHA
    2655919 View commit details
    Browse the repository at this point in the history

  7. remove owning_resource from image_data

    @stf976
    stf976 committed Apr 25, 2021
    Configuration menu
    Copy the full SHA
    c20685b View commit details
    Browse the repository at this point in the history

  8. use only a single descriptor cache for both pipelines

    @stf976
    stf976 committed Apr 25, 2021
    Configuration menu
    Copy the full SHA
    373e123 View commit details
    Browse the repository at this point in the history

  9. add mirror_matrix and cancel_translation_from_matrix helper functions

    @stf976
    stf976 committed Apr 25, 2021
    Configuration menu
    Copy the full SHA
    54cd2c9 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2021

  1. use enum to define axis in mirror_matrix 

    follow naming guidelines for parameters
    @stf976
    stf976 committed May 10, 2021
    4 Configuration menu
    Copy the full SHA
    321d016 View commit details
    Browse the repository at this point in the history

  2. update auto_vk ref

    @stf976
    stf976 committed May 10, 2021
    Configuration menu
    Copy the full SHA
    14bc637 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of https://github.com/cg-tuwien/Gears-Vk into c… 

    …reate_cubemap_from_file
    @stf976
    stf976 committed May 10, 2021
    Configuration menu
    Copy the full SHA
    131a95d View commit details
    Browse the repository at this point in the history

  4. update description of texture_cubemap shaders, add newline 

    Co-authored-by: Johannes Unterguggenberger <[email protected]>
    @stf976 @johannesugb
    stf976 and johannesugb authored May 10, 2021
    Configuration menu
    Copy the full SHA
    d40fdfd View commit details
    Browse the repository at this point in the history

  5. don't explicitly specify image format for image view

    @stf976
    stf976 committed May 10, 2021
    Configuration menu
    Copy the full SHA
    ab98735 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'create_cubemap_from_file' of https://github.com/cg-tuwi… 

    …en/Gears-Vk into create_cubemap_from_file
    @stf976
    stf976 committed May 10, 2021
    Configuration menu
    Copy the full SHA
    c527559 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2021

  1. use enum struct instead of old style enum 

    fix parameter type
    @stf976
    stf976 committed May 11, 2021
    Configuration menu
    Copy the full SHA
    0301fb0 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2021

  1. - Restructured texture_cubemap example a bit by introducing `enum str… 

    …uct options`. This should improve readability.

- Removed useless `updater` calls and restructured the remaining code to be clearer.
- Added comments to the functions in `math_utils.hpp` that are added with this PR
- Removed default parameter value for `mirror_matrix`'s `principal_axis` parameter. There is not really a justification why any of the axes should be the default. The user must be precise anyways. Also removed the parameter's `const` declaration.
    @johannesugb
    johannesugb committed May 12, 2021
    Configuration menu
    Copy the full SHA
    4f03ea2 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2021

  1. Linked to latest Auto-Vk master which includes necessary changes for … 

    …this PR.
    @johannesugb
    johannesugb committed May 17, 2021
    Configuration menu
    Copy the full SHA
    593337e View commit details
    Browse the repository at this point in the history

  2. don't try to flip gli texture if it wasn't loaded successfully

    @stf976
    stf976 committed May 17, 2021
    Configuration menu
    Copy the full SHA
    4546deb View commit details
    Browse the repository at this point in the history

  3. Merge branch 'create_cubemap_from_file' of https://github.com/cg-tuwi… 

    …en/Gears-Vk into create_cubemap_from_file
    @stf976
    stf976 committed May 17, 2021
    Configuration menu
    Copy the full SHA
    51aa1c1 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2021

  1. Merge branch 'master' into create_cubemap_from_file

    @johannesugb
    johannesugb committed May 18, 2021
    Configuration menu
    Copy the full SHA
    16cd3d2 View commit details
    Browse the repository at this point in the history

  2. Fixed RELEASE-mode project config in texture_cubemap.vcxproj.user

    @johannesugb
    johannesugb committed May 18, 2021
    Configuration menu
    Copy the full SHA
    76c7d0e View commit details
    Browse the repository at this point in the history