✨ Dio.clone
#2095
Draft
✨ Dio.clone
#2095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Independent of this PR, what do you think of making the Dio instance completely immutable in version 6? |
Yeah I like the idea, and I'm also exploring the path. The thing is Dio's structure makes pieces nested, we cannot fluently use Dio in cases of grouping usage. So going immutable might be a better path to improve the overall usability and readability. About the grouping usage, you can read this through translation: https://juejin.cn/post/7213356423811366949 |
AlexV525
force-pushed
the
main
branch
2 times, most recently
from
4d616d5
to
6ad7313
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
mainbranch to avoid conflicts (via merge from master or rebase)CHANGELOG.mdin the corresponding packageAdditional context and info (if any)