Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a quick hack to figure out if we can get rid of
DioMixin
and if that would actually make sense.The
DioMixin
is currently the main class. TheDioForNative
andDioForBrowser
classes contain minimal logic for download handling.We can extract this logic into some new platform specific
DownloadAdapter
in the same way theHttpClientAdapter
works.At the same time we can combine the
DioMixin
andDio
classes.This should overall reduce the complexity of having 4 different
Dio*
classesI think this would be a good change, not totally happy with passing 2 more parameters to the download handler yet.
What do you think @cfug/devs?
New Pull Request Checklist
main
branch to avoid conflicts (via merge from master or rebase)CHANGELOG.md
in the corresponding packageAdditional context and info (if any)