Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Node v22 #1047

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Upgrade to Node v22 #1047

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
52300a3
fix: [ViewInstitutionProfile] Types of FI: Avoid blank display for em…
meissadia Nov 6, 2024
04f0135
e2e: [InstitutionProfile] Update tests to match latest language changes
meissadia Nov 6, 2024
5078eb3
deps: Upgrade to Node v22
meissadia Nov 6, 2024
628c030
Merge branch 'main' into 1040-node-22
meissadia Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v18
v22
12 changes: 9 additions & 3 deletions e2e/pages/shared-lending-platform/InstitutionProfile.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ test('Institution Profile Page', async ({
await expect(
page.locator('#main h3').nth(3).locator('xpath=../p[1]'),
'LEI status is correct',
).toContainText('Active');
).toContainText('Issued');
});

// Email domains
Expand Down Expand Up @@ -147,8 +147,14 @@ test('Institution Profile Page', async ({
).toContainText('Type of financial institution');
await expect(
page.locator('#main h3').nth(8).locator('xpath=../p[1]'),
'Type is correct',
).toContainText('Not available');
'Type is correct when not provided',
).toContainText('Not provided');
await expect(
page.locator('#main h3').nth(8).locator('xpath=../div/span[2]/p'),
'Alert for unprovided Type of FI',
).toContainText(
'You must provide your type of financial institution to file.',
);
});
});

Expand Down
4 changes: 3 additions & 1 deletion src/pages/Filing/ViewInstitutionProfile/IdentifyingInformation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,9 @@ export function IdentifyingInformation({
},
);

const institutionTypeNamesString = institutionTypeNamesArray?.join(', ');
const institutionTypeNamesString = institutionTypeNamesArray?.length
? institutionTypeNamesArray.join(', ')
: null;

return (
<FormSectionWrapper>
Expand Down
Loading